-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing aria-label for discover page #6898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6898 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 3442 3442
Lines 67816 67816
Branches 11027 11027
=======================================
Hits 45740 45740
Misses 19409 19409
Partials 2667 2667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
do you have the changelog bot installed for your github? |
Hi @abbyhu2000 , is this PR targeting 2.15 or 2.16? |
It is for 2.15, i have added the label |
c007889
to
e46454b
Compare
src/plugins/discover/public/application/components/doc_viewer_links/doc_viewer_links.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/table/table_row.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/top_nav/get_top_nav_links.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/top_nav/get_top_nav_links.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/top_nav/get_top_nav_links.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/top_nav/get_top_nav_links.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/top_nav/get_top_nav_links.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ce6a751
to
96c2781
Compare
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6898-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e2f23802d7ba25ec8020c5a454f2a0ed435b78d7
# Push it to GitHub
git push --set-upstream origin backport/backport-6898-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* add missing aria-label for discover page * Update snapshot * add localization and make it human-readable --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
* Add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add another changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit e21c17a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add changelog * add another changelog --------- (cherry picked from commit e21c17a) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add another changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Michael Haitz <admin@doridina.de>
* Add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add another changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Michael Haitz <admin@doridina.de>
Description
Add missing aria-label for discover page.
Issues Resolved
resolves 1.1.1 Non-text Content (Level A) Web of #6897
Changelog