[MD]Remove endpoint validation for create data source saved object API #6899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
zhongnansu
force-pushed
the
remove-endpoint-validation
branch
from
028bec3
to
4df45cf
Compare
opensearch-changeset-bot bot
added a commit
to zhongnansu/OpenSearch-Dashboards
that referenced
this pull request
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6899 +/- ##
==========================================
- Coverage 67.42% 67.41% -0.02%
==========================================
Files 3444 3443 -1
Lines 67781 67770 -11
Branches 11023 11023
==========================================
- Hits 45702 45687 -15
- Misses 19413 19417 +4
Partials 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
pushed a commit
to zhongnansu/OpenSearch-Dashboards
that referenced
this pull request
Jun 4, 2024
zhongnansu
force-pushed
the
remove-endpoint-validation
branch
from
85748cc
to
911bd26
Compare
zhongnansu
changed the title
zhongnansu
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
zhyuanqi
approved these changes
Jun 5, 2024
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
zhongnansu
force-pushed
the
remove-endpoint-validation
branch
from
911bd26
to
71f7f4d
Compare
ZilongX
approved these changes
Jun 5, 2024
bandinib-amzn
approved these changes
Jun 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
#6899) * Remove endpoint validation for create data source saved object API Signed-off-by: Zhongnan Su <szhongna@amazon.com> * Changeset file for PR #6899 created/updated --------- Signed-off-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 47bd391) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Jun 5, 2024
#6899) (#6927) * Remove endpoint validation for create data source saved object API * Changeset file for PR #6899 created/updated --------- (cherry picked from commit 47bd391) Signed-off-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to enable user to import data source, but this is conflict with previously added endpoint validation from create data source saved object API. So we decide to remove endpoint validation in api level.
can create data source
can import data source
Issues Resolved
#6893
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration