[Multi DataSource] Add removedComponentIds for data source selection service #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
github-actions
bot
added
seasoned-contributor
Skip-Changelog
|
Need help to add backport 2.x label. |
SuZhou-Joe
previously approved these changes
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6920 +/- ##
==========================================
+ Coverage 67.44% 67.46% +0.01%
==========================================
Files 3443 3443
Lines 67811 67815 +4
Branches 11032 11033 +1
==========================================
+ Hits 45732 45748 +16
+ Misses 19413 19401 -12
Partials 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhongnansu
removed
the
Skip-Changelog
opensearch-changeset-bot bot
added a commit
to raintygao/OpenSearch-Dashboards
that referenced
this pull request
Jun 6, 2024
zhongnansu
approved these changes
Jun 6, 2024
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
SuZhou-Joe
approved these changes
Jun 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
…service (#6920) * add removedComponentIds for data source selection service to fallback Signed-off-by: tygao <tygao@amazon.com> * update comment Signed-off-by: tygao <tygao@amazon.com> * update component variable snapshot in navigation plugin Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #6920 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <nluyu@amazon.com> (cherry picked from commit efab1a8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jun 6, 2024
…service (#6920) (#6944) * add removedComponentIds for data source selection service to fallback * update comment * update component variable snapshot in navigation plugin * Changeset file for PR #6920 created/updated --------- (cherry picked from commit efab1a8) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <nluyu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add removedComponentIds for data source selection service.
In the implementation of some selector components, it may call onSelect function in promise.then or after await, which could be executed later than componentWillUnmount.
If some components do not use memorize and frequently unmount and mount, it is possible that the set function is triggered and selected data source stored after the componentWillUnmount emit. The security analytics page is currently known which may cause this problem.
Screenshot
No UI updates
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration