Modify the import for timeline visualization to includes data source name in MDS scenario #6954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyuanqi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba and
mengweieric
as code owners
opensearch-changeset-bot bot
added a commit
to zhyuanqi/OpenSearch-Dashboards
that referenced
this pull request
Jun 6, 2024
zhyuanqi
added
backport 2.x
multiple datasource
zhyuanqi
force-pushed
the
import_timeline
branch
2 times, most recently
from
2964780
to
03ccc53
Compare
opensearch-changeset-bot bot
added a commit
to zhyuanqi/OpenSearch-Dashboards
that referenced
this pull request
Jun 6, 2024
zhyuanqi
changed the title
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
opensearch-changeset-bot bot
added a commit
to zhyuanqi/OpenSearch-Dashboards
that referenced
this pull request
Jun 6, 2024
opensearch-changeset-bot bot
added a commit
to zhyuanqi/OpenSearch-Dashboards
that referenced
this pull request
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6954 +/- ##
==========================================
+ Coverage 67.44% 67.46% +0.02%
==========================================
Files 3442 3442
Lines 67804 67816 +12
Branches 11025 11027 +2
==========================================
+ Hits 45730 45754 +24
+ Misses 19408 19396 -12
Partials 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
45 tasks
zhongnansu
previously approved these changes
Jun 6, 2024
huyaboo
reviewed
Jun 6, 2024
src/core/server/saved_objects/import/check_conflict_for_data_source.test.ts
Show resolved
Hide resolved
zhyuanqi
force-pushed
the
import_timeline
branch
4 times, most recently
from
728b135
to
3f04f37
Compare
…name in MDS scenario Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com>
zhongnansu
approved these changes
Jun 7, 2024
huyaboo
approved these changes
Jun 7, 2024
ZilongX
approved these changes
Jun 7, 2024
zhyuanqi
pushed a commit
that referenced
this pull request
Jun 7, 2024
…name in MDS scenario (#6954) (#6975) (cherry picked from commit 7eaab64) Signed-off-by: Yuanqi(Ella) Zhu <zhyuanqi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the import for timeline visualization to includes data source name in MDS scenario
Issues Resolved
#6919
Testing the changes
Add data source name when import non-mds timeline to mds timeline
Screen.Recording.2024-06-06.at.1.25.20.PM.mov
When import from MDS to MDS, the data source name stays the same in timeline
Screen.Recording.2024-06-06.at.1.30.01.PM.mov
Import for overwriting scenerio
Screen.Recording.2024-06-06.at.1.31.16.PM.mov
Changelog
Check List
yarn test:jestyarn test:jest_integration