Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Data Explorer] Allow render from View directly, not from Data Explorer #6959

Merged
merged 1 commit into from
Jun 7, 2024

Commits on Jun 6, 2024

  1. [Data Explorer] Allow render from View directly, not from Data Explor…

    …er (#6167)
    
    * [Discover] Remove double render
    
    This PR avoids re-rendering the entire AppContainer when data services update.
    The re-render is caused by history object which is in AppMountParameters. This
    history object is part of the application's routing context and can change frequently
    as the url is updated by query, filter or time range. Each change in the history object
    could potentially trigger a re-render of the AppContainer and its child components.
    
    With this PR, the AppContainer will not be re-loaded. Instead each component, like Canvas
    and Panel, will be updated.
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    
    * fix PR comment
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    
    ---------
    
    Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    (cherry picked from commit b792242)
    Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    github-actions[bot] committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0d39353 View commit details
    Browse the repository at this point in the history