Update sidecar z-index style #6964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tygao <tygao@amazon.com>
raintygao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6964 +/- ##
==========================================
- Coverage 67.45% 67.42% -0.04%
==========================================
Files 3444 3445 +1
Lines 67849 67827 -22
Branches 11035 11036 +1
==========================================
- Hits 45766 45730 -36
- Misses 19417 19427 +10
- Partials 2666 2670 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Jun 7, 2024
SuZhou-Joe
approved these changes
Jun 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
* update sidecar style Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #6964 created/updated --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e7f28f4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Jun 7, 2024
* update sidecar style * Changeset file for PR #6964 created/updated --------- (cherry picked from commit e7f28f4) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update sidecar z-index from 1000 to 1001.
The mask in UI component will cover the entire screen, even if their child element flyout has left or right, they will still cover the entire screen. As a container independent of OSD, sidecar should not be blocked by redundant masks.
Screenshot
Before
After
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration