-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHSA-x565-32qp-m3vf] Bump jimp
to remove phin dependency
#6977
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6977.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6977 +/- ##
=======================================
Coverage 67.44% 67.45%
=======================================
Files 3442 3442
Lines 67816 67816
Branches 11027 11027
=======================================
+ Hits 45740 45742 +2
+ Misses 19409 19408 -1
+ Partials 2667 2666 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jimp 0.22.12 is still using phin 2.9.1 right? 😃 |
Does look like it:
|
|
`jimp@0.22.0` removed all the code that used phin. `load-bmfont`, a nested dependency of `jimp` imports `phin` but that is a functionality we don't use as we don't import AngleCode bitmap fonts. With an arbitrarily bump of `phin`, this commit avoids including an offending version in the dev-deps. Signed-off-by: Miki <miki@amazon.com>
Cool. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6977-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 54cd2d0f920fc25210339bd66256235a32ef6cce
# Push it to GitHub
git push --set-upstream origin backport/backport-6977-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…ch-project#6977) `jimp@0.22.0` removed all the code that used phin. `load-bmfont`, a nested dependency of `jimp` imports `phin` but that is a functionality we don't use as we don't import AngleCode bitmap fonts. With an arbitrarily bump of `phin`, this commit avoids including an offending version in the dev-deps. Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 54cd2d0) Signed-off-by: Miki <miki@amazon.com>
…6985) `jimp@0.22.0` removed all the code that used phin. `load-bmfont`, a nested dependency of `jimp` imports `phin` but that is a functionality we don't use as we don't import AngleCode bitmap fonts. With an arbitrarily bump of `phin`, this commit avoids including an offending version in the dev-deps. (cherry picked from commit 54cd2d0) Signed-off-by: Miki <miki@amazon.com>
[GHSA-x565-32qp-m3vf] Bump
jimp
to remove phin dependencyjimp@0.22.0
removed all the code that used phin.load-bmfont
, a nested dependency ofjimp
importsphin
but that is a functionality we don't use as we don't import AngleCode bitmap fonts. With an arbitrarily bump ofphin
, this commit avoids including an offending version in the dev-deps.Changelog
Check List
yarn test:jest
yarn test:jest_integration