[Discover] Allow the last column of a table wider than the window to show up properly #7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 7058.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
AMoo-Miki
force-pushed
the
discover-table-last-col
branch
from
75c3eb8
to
443bb09
Compare
ananzh
previously approved these changes
Jun 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7058 +/- ##
==========================================
+ Coverage 67.44% 67.46% +0.01%
==========================================
Files 3445 3445
Lines 67886 67886
Branches 11037 11037
==========================================
+ Hits 45788 45800 +12
+ Misses 19431 19419 -12
Partials 2667 2667
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
previously approved these changes
Jun 19, 2024
ruanyl
reviewed
Jun 19, 2024
...ins/discover/public/application/components/default_discover_table/default_discover_table.tsx
Outdated
Show resolved
Hide resolved
…show up properly Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
discover-table-last-col
branch
from
443bb09
to
9849ede
Compare
kavilla
approved these changes
Jun 19, 2024
zhyuanqi
approved these changes
Jun 19, 2024
mengweieric
pushed a commit
to mengweieric/OpenSearch-Dashboards
that referenced
this pull request
Jun 24, 2024
…show up properly (opensearch-project#7058) Signed-off-by: Miki <miki@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last column on a table wider than the screen was crushed.
Issues Resolved
Fixes #7056
Changelog
Check List
yarn test:jestyarn test:jest_integration