Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message in timeline visualization when MDS disabled #7069

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Update error message in timeline visualization when MDS disabled #7069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e030b8
Update error message in timeline visualization when MDS disabled
zhongnansu Jun 19, 2024
77eb903
Changeset file for PR #7069 created/updated
opensearch-changeset-bot[bot] Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7069.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Update error message in timeline visualization when MDS disabled ([#7069](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7069))
2 changes: 1 addition & 1 deletion src/plugins/vis_type_timeline/server/lib/fetch_data_source_id.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ describe('fetchDataSourceIdByName()', () => {
await expect(
fetchDataSourceIdByName({ ...config, data_source_name: 'Some Data Source' }, client)
).rejects.toThrowError(
'To query from multiple data sources, first enable the data source feature'
'data_source_name is not supported. Contact your administrator to start using multiple data sources'
);
});

Expand Down
4 changes: 3 additions & 1 deletion src/plugins/vis_type_timeline/server/lib/fetch_data_source_id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ export const fetchDataSourceIdByName = async (
}

if (!getDataSourceEnabled().enabled) {
throw new Error('To query from multiple data sources, first enable the data source feature');
throw new Error(
'data_source_name is not supported. Contact your administrator to start using multiple data sources'
);
}

const dataSources = await client.find<DataSourceAttributes>({
Expand Down
Loading