Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover-next] dataframes respects datasources #7092

Closed
wants to merge 3 commits into from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jun 24, 2024

Description

Parses user string between ::datasource:: to get the data source Then appends the dataSourceId in the meta.

Also creates the data frame before the interceptor to keep the meta info passed around.

If this gets accepted follow ups need to happen:

  • should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state.
  • some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted
  • weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected
  • better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial ::.

Issues Related

#6957

Screenshot

Screenshot 2024-06-24 at 1 42 56 AM

Testing the changes

run yarn opensearch snapshot --sql
run yarn start:enhancements

add a new data source connection

Changelog

  • feat: onboard dataframes to MDS

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Parses user string between `::datasource::` to get the data source
Then appends the dataSourceId in the meta.

Also creates the data frame before the interceptor to keep the meta
info passed around.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

❌ Invalid Prefix

Invalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

Copy link
Contributor

❌ Invalid Prefix

Invalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

1 similar comment
Copy link
Contributor

❌ Invalid Prefix

Invalid description prefix. Found "". Expected "breaking", "deprecate", "feat", "fix", "infra", "doc", "chore", "refactor", "security", "skip", or "test".

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 3.44828% with 28 lines in your changes missing coverage. Please review.

Project coverage is 67.42%. Comparing base (7f0e9d0) to head (371869c).

Files Patch % Lines
.../data/common/search/search_source/search_source.ts 0.00% 9 Missing ⚠️
src/plugins/data/common/data_frames/utils.ts 11.11% 8 Missing ⚠️
src/plugins/data/public/search/search_service.ts 0.00% 4 Missing ⚠️
src/plugins/data/server/search/search_service.ts 0.00% 4 Missing ⚠️
...on/index_patterns/index_patterns/index_patterns.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7092      +/-   ##
==========================================
- Coverage   67.45%   67.42%   -0.03%     
==========================================
  Files        3448     3448              
  Lines       67916    67945      +29     
  Branches    11042    11052      +10     
==========================================
+ Hits        45812    45815       +3     
- Misses      19435    19462      +27     
+ Partials     2669     2668       -1     
Flag Coverage Δ
Linux_1 33.05% <3.44%> (-0.02%) ⬇️
Linux_2 55.05% <4.00%> (-0.06%) ⬇️
Linux_3 45.23% <3.44%> (-0.05%) ⬇️
Linux_4 34.83% <3.44%> (-0.03%) ⬇️
Windows_1 33.08% <3.44%> (-0.02%) ⬇️
Windows_2 55.00% <4.00%> (-0.06%) ⬇️
Windows_3 45.26% <3.44%> (-0.03%) ⬇️
Windows_4 34.83% <3.44%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla closed this Jun 25, 2024
kavilla pushed a commit that referenced this pull request Jun 26, 2024
Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta.

Also creates the data frame before the interceptor to keep the meta info passed around.

If this gets accepted follow ups need to happen:
* should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state.
* some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted
* weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected
* better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`.

Rebase of #7092 

Issue:
#6957

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Jun 27, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 1, 2024
Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta.

Also creates the data frame before the interceptor to keep the meta info passed around.

If this gets accepted follow ups need to happen:
* should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state.
* some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted
* weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected
* better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`.

Rebase of #7092

Issue:
#6957

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d3d1c43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Jul 1, 2024
)

Parses user string between `::datasource::` to get the data source Then appends the dataSourceId in the meta.

Also creates the data frame before the interceptor to keep the meta info passed around.

If this gets accepted follow ups need to happen:
* should be ensuring the virtual index pattern includes the data source name with the index pattern name to avoid conflicts and a weird state.
* some reason dataframe is being always wiped out the first call in the search source. need to fix so that the schema is persisted
* weird initial load state. likely just too many things at once so we should make sure the usual and fresh experience is respected
* better indicator on the datasource, or just autocomplete that displays all the datasource connections when user types initial `::`.

Rebase of #7092

Issue:
#6957

---------

(cherry picked from commit d3d1c43)

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant