Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] kbn-config-schema to osd-config-scheme #71

Merged

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 5, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issue #, if available:
#37

Description of changes:
Rename folders, files, and variables within kbn-config-schema.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! Probably let's add this into doc for URLs follow http://opensearch-dashboards.local

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla force-pushed the rename-kbn-config-schema-2 branch from e9e3db3 to 11996c7 Compare March 6, 2021 00:01
@kavilla kavilla requested a review from mihirsoni March 6, 2021 00:01
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@mihirsoni mihirsoni merged commit 12cac9f into opensearch-project:dashboards Mar 6, 2021
@mihirsoni mihirsoni deleted the rename-kbn-config-schema-2 branch March 6, 2021 03:57
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] kbn-config-schema to osd-config-scheme

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Handle PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
* [Rename] kbn-config-schema to osd-config-scheme

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Handle PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] kbn-config-schema to osd-config-scheme

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Handle PR comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 10, 2023
…ject#71)

* feat: update public workspace

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* refractor: change public objects logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: create public workspace when service start

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some modify

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feature: some optimize and create workspace when ui settings is open

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* temp: submit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update query dsl

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use same constants

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make it run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove dashboard admin

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: list principals route

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change public logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove init

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add judgement when workspaceList is empty

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…ject#71)

* feat: update public workspace

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* refractor: change public objects logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: create public workspace when service start

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some modify

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feature: some optimize and create workspace when ui settings is open

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* temp: submit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update query dsl

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use same constants

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make it run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove dashboard admin

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: list principals route

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change public logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove init

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add judgement when workspaceList is empty

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…ject#71)

* feat: update public workspace

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* refractor: change public objects logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: create public workspace when service start

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: some modify

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feature: some optimize and create workspace when ui settings is open

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* temp: submit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update query dsl

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: use same constants

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make it run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove dashboard admin

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: modify query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: list principals route

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize query DSL

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change public logic

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: remove init

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add judgement when workspaceList is empty

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants