[Navigation-next] Add register nav group updater to nav group service #7117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jun 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7117 +/- ##
==========================================
+ Coverage 67.48% 67.50% +0.01%
==========================================
Files 3468 3468
Lines 68381 68402 +21
Branches 11114 11117 +3
==========================================
+ Hits 46150 46172 +22
+ Misses 19534 19533 -1
Partials 2697 2697
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
force-pushed
the
feature/navigation-next
branch
2 times, most recently
from
b56b057
to
ac790af
Compare
wanglam
force-pushed
the
add-register-nav-group-updater
branch
from
9fad488
to
d1821b5
Compare
wanglam
changed the title
opensearch-changeset-bot bot
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Jul 1, 2024
wanglam
force-pushed
the
add-register-nav-group-updater
branch
2 times, most recently
from
d1821b5
to
1466493
Compare
SuZhou-Joe
force-pushed
the
feature/navigation-next
branch
from
ac790af
to
8481ba5
Compare
wanglam
force-pushed
the
add-register-nav-group-updater
branch
from
1466493
to
4e02312
Compare
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
force-pushed
the
add-register-nav-group-updater
branch
from
4e02312
to
69bac44
Compare
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
curq
as code owners
wanglam
requested review from
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
SuZhou-Joe
approved these changes
Jul 2, 2024
ZilongX
approved these changes
Jul 3, 2024
ruanyl
approved these changes
Jul 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
…#7117) * Add registerNavGroupUpdater to nav group service Signed-off-by: Lin Wang <wonglam@amazon.com> * Register navGroupUpdater in workspace plugin Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #7117 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 417246b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 4, 2024
…#7117) (#7167) * Add registerNavGroupUpdater to nav group service * Register navGroupUpdater in workspace plugin * Changeset file for PR #7117 created/updated --------- (cherry picked from commit 417246b) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #7029, we introduce a new concept of nav group. When user enter a workspace, the nav group in the left navigation should be shrink according the specific workspace setting. In order to update the nav group, add a registerNavGroupUpdater in the chrome service. The plugin can register their updaters by using the new function.
Issues Resolved
#7147
Screenshot
Testing the changes
For chrome service changes, can reference
src/core/public/chrome/chrome_service.test.ts.For workspace plugin changes, can reference
src/plugins/workspace/public/plugin.test.ts.Changelog
Check List
yarn test:jestyarn test:jest_integration