Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources #7146

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

ZilongX
Copy link
Collaborator

@ZilongX ZilongX commented Jul 2, 2024

Description

  • This PR is to add support of Version Decoupling in Index Patterns Dashboards Plugin
  • This PR is to add a new entry requiredOSDataSourcePlugins in the plugin manifest file
  • The current behavior is to filter out the incompatible data sources out of the data source list.
  • As called out in [FEATURE] Support Version Decoupling in Index Patterns Dashboards Plugin #7099 (comment), will improve the general code coverage of Index Pattern plugin in separate changes.

Issues Resolved

#7099

Testing the changes

7146.mov

Changelog

  • fix: [MDS][Version Decoupling] Add support of required backend plugins check on data sources

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…kend plugins check on data sources

Signed-off-by: Zilong Xia <zilongx@amazon.com>
@ZilongX ZilongX changed the title [Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources Pending test recordings - [Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (5e19749) to head (176c7db).

Files Patch % Lines
...ents/step_data_source/components/header/header.tsx 0.00% 7 Missing ⚠️
...ndex_pattern_management/public/components/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7146      +/-   ##
==========================================
- Coverage   67.49%   67.48%   -0.01%     
==========================================
  Files        3468     3468              
  Lines       68366    68375       +9     
  Branches    11110    11114       +4     
==========================================
+ Hits        46143    46146       +3     
- Misses      19523    19529       +6     
  Partials     2700     2700              
Flag Coverage Δ
Linux_1 33.05% <0.00%> (-0.01%) ⬇️
Linux_2 55.19% <100.00%> (+<0.01%) ⬆️
Linux_3 45.35% <0.00%> (+<0.01%) ⬆️
Linux_4 34.76% <0.00%> (-0.01%) ⬇️
Windows_1 33.07% <0.00%> (-0.01%) ⬇️
Windows_2 55.14% <100.00%> (+<0.01%) ⬆️
Windows_3 45.35% <0.00%> (-0.02%) ⬇️
Windows_4 34.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZilongX ZilongX changed the title Pending test recordings - [Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources [Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources Jul 2, 2024
@ZilongX ZilongX added the v2.16.0 label Jul 2, 2024
@ZilongX ZilongX merged commit daccab7 into opensearch-project:main Jul 2, 2024
78 of 79 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 2, 2024
…kend plugins check on data sources (#7146)

* [Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources

Signed-off-by: Zilong Xia <zilongx@amazon.com>

* Changeset file for PR #7146 created/updated

---------

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit daccab7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
RyanL1997 pushed a commit to RyanL1997/OpenSearch-Dashboards that referenced this pull request Jul 2, 2024
…kend plugins check on data sources (opensearch-project#7146)

* [Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources

Signed-off-by: Zilong Xia <zilongx@amazon.com>

* Changeset file for PR opensearch-project#7146 created/updated

---------

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ZilongX pushed a commit that referenced this pull request Jul 3, 2024
…kend plugins check on data sources (#7146) (#7161)

* [Multiple Datasource][Version Decoupling] Add support of required backend plugins check on data sources



* Changeset file for PR #7146 created/updated

---------



(cherry picked from commit daccab7)

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants