Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVE] Bump up axios to 1.7.2 to fix SNYK-JS-AXIOS-6144788 #7149

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ZilongX
Copy link
Collaborator

@ZilongX ZilongX commented Jul 2, 2024

Description

  • This one is to fix SNYK-JS-AXIOS-6144788 by bump up axios to 1.7.2

Issues Resolved

https://security.snyk.io/vuln/SNYK-JS-AXIOS-6144788

Changelog

  • security: [SNYK-JS-AXIOS-6144788] Bump axios to 1.7.2

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Zilong Xia <zilongx@amazon.com>
@ZilongX ZilongX added v2.16.0 backport 2.x cve Security vulnerabilities detected by Dependabot or Mend labels Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.49%. Comparing base (9ac3184) to head (2df8c76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7149   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        3468     3468           
  Lines       68363    68363           
  Branches    11110    11110           
=======================================
  Hits        46140    46140           
  Misses      19523    19523           
  Partials     2700     2700           
Flag Coverage Δ
Linux_1 33.04% <ø> (ø)
Linux_2 55.18% <ø> (ø)
Linux_3 45.35% <ø> (-0.02%) ⬇️
Linux_4 34.77% <ø> (ø)
Windows_1 33.06% <ø> (ø)
Windows_2 55.14% <ø> (ø)
Windows_3 45.36% <ø> (ø)
Windows_4 34.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZilongX ZilongX merged commit 027122e into opensearch-project:main Jul 2, 2024
73 checks passed
@ZilongX ZilongX deleted the SNYK-JS-AXIOS-6144788 branch July 2, 2024 17:12
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7149-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 027122ef196fc958da1a565d6f2f4823d9e0ea44
# Push it to GitHub
git push --set-upstream origin backport/backport-7149-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7149-to-2.x.

LDrago27 pushed a commit to LDrago27/OpenSearch-Dashboards that referenced this pull request Jul 25, 2024
…-project#7149)

* [CVE] Bump up axios to 1.7.2 to fix SNYK-JS-AXIOS-6144788

Signed-off-by: Zilong Xia <zilongx@amazon.com>

* Changeset file for PR opensearch-project#7149 created/updated

---------

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 027122e)
LDrago27 added a commit that referenced this pull request Jul 25, 2024
)

* [CVE] Bump up axios to 1.7.2 to fix SNYK-JS-AXIOS-6144788

Signed-off-by: Zilong Xia <zilongx@amazon.com>

* Changeset file for PR #7149 created/updated

---------

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 027122e)

Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x cve Security vulnerabilities detected by Dependabot or Mend seasoned-contributor v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants