[Workspace] Delete the virtual global workspace #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7165 +/- ##
=======================================
Coverage 67.54% 67.55%
=======================================
Files 3469 3469
Lines 68502 68478 -24
Branches 11140 11130 -10
=======================================
- Hits 46273 46263 -10
+ Misses 19524 19512 -12
+ Partials 2705 2703 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
…enSearch-Dashboards into 2.16-delete-global-workspace
Signed-off-by: yubonluo <yubonluo@amazon.com>
…oards into 2.16-delete-global-workspace
…enSearch-Dashboards into 2.16-delete-global-workspace
SuZhou-Joe
reviewed
Jul 3, 2024
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
ruanyl
previously approved these changes
Jul 8, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
…enSearch-Dashboards into 2.16-delete-global-workspace
ruanyl
previously approved these changes
Jul 8, 2024
src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
|
I like these changes, after removing the special "artificial" workspace, the code smells much better 😃 |
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
approved these changes
Jul 8, 2024
ruanyl
approved these changes
Jul 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
* Delete the virtual global workspace Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7165 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete the useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete the useless code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 20cefab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Delete the virtual global workspace * Changeset file for PR #7165 created/updated * optimize the code * optimize the code * optimize the code * optimize the code * delete the useless code * delete the useless code --------- (cherry picked from commit 20cefab) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Delete the virtual global workspace.
When workspace feature flag is enabled and user has not created any workspace, only OSD admin user can see any legacy saved object (not belonging to any workspace) on the home page. Non OSD admin users should not see the legacy saved objects if they can not access any workspace.
Issues Resolved
#7095
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration