-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation-Next] Add current nav group into chrome service #7166
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7166 +/- ##
=======================================
Coverage 67.55% 67.56%
=======================================
Files 3469 3469
Lines 68479 68515 +36
Branches 11130 11140 +10
=======================================
+ Hits 46264 46292 +28
- Misses 19512 19516 +4
- Partials 2703 2707 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hailong Cui <ihailong@amazon.com> breadcrumbs Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7166-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0215e322d9bd6e6e41015db7770f95df89d6eb0b
# Push it to GitHub
git push --set-upstream origin backport/backport-7166-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…ch-project#7166) * Add current nav group into chrome service Signed-off-by: Hailong Cui <ihailong@amazon.com> breadcrumbs Signed-off-by: Hailong Cui <ihailong@amazon.com> * prepend nav group into breadcrumbs Signed-off-by: Hailong Cui <ihailong@amazon.com> * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove lodash import Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR opensearch-project#7166 created/updated * fix bootstrap error Signed-off-by: Hailong Cui <ihailong@amazon.com> * add nav group status check Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * update snapshot Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 0215e32)
…7229) * Add current nav group into chrome service Signed-off-by: Hailong Cui <ihailong@amazon.com> breadcrumbs Signed-off-by: Hailong Cui <ihailong@amazon.com> * prepend nav group into breadcrumbs Signed-off-by: Hailong Cui <ihailong@amazon.com> * add unit test Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove lodash import Signed-off-by: Hailong Cui <ihailong@amazon.com> * Changeset file for PR #7166 created/updated * fix bootstrap error Signed-off-by: Hailong Cui <ihailong@amazon.com> * add nav group status check Signed-off-by: Hailong Cui <ihailong@amazon.com> * address review comments Signed-off-by: Hailong Cui <ihailong@amazon.com> * update snapshot Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 0215e32)
Description
Issues Resolved
#7131, #7132
Screenshot
Testing the changes
app/management/opensearch-dashboards/settings
to enableUse New Home Page
(nav group share same configuration)sessionStorage.setItem('core.chrome.currentNavGroupId','analytics')
Changelog
Check List
yarn test:jest
yarn test:jest_integration