Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource][Version Decoupling] Add data source version and installed plugins in MDS data source viewer returns #7172

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

ZilongX
Copy link
Collaborator

@ZilongX ZilongX commented Jul 3, 2024

Description

  • This one is to add fields dataSourceVersion and installedPlugins in all data source viewers.
  • These two metadata would be consumed by plugins to perform data source filtering and decoupling check

Issues Resolved

#7099

Screenshot

Screenshot 2024-07-03 at 4 33 19 PM

Changelog

  • fix: [MDS][Version Decoupling] Add dataSourceVersion' and 'installedPlugins in viewer returns

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

… installed plugins in MDS data source viewer returns

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Entry Too Long

Entry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Entry Too Long

Entry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

2 similar comments
Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Entry Too Long

Entry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Entry Too Long

Entry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Entry Too Long

Entry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

2 similar comments
Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Entry Too Long

Entry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Entry Too Long

Entry is 106 characters long, which is 6 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (1cb5956) to head (fc6af23).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7172   +/-   ##
=======================================
  Coverage   67.57%   67.58%           
=======================================
  Files        3469     3469           
  Lines       68497    68499    +2     
  Branches    11138    11138           
=======================================
+ Hits        46288    46292    +4     
+ Misses      19503    19502    -1     
+ Partials     2706     2705    -1     
Flag Coverage Δ
Linux_1 33.15% <ø> (ø)
Linux_2 55.25% <ø> (ø)
Linux_3 45.31% <100.00%> (?)
Linux_4 34.72% <0.00%> (-0.01%) ⬇️
Windows_1 33.20% <ø> (ø)
Windows_2 55.21% <ø> (ø)
Windows_3 45.32% <100.00%> (+<0.01%) ⬆️
Windows_4 34.72% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavilla
Copy link
Member

kavilla commented Jul 4, 2024

This is cool. Thank you!

I haven't looked how this is set. Like is this set just one time when the datasource is added or is it anytime the datasource is selected?

Also do we plan on utilizing the capabilities service, for example link. For example, query assist there could be ML commons installed but doesn't have the chat feature.

We could use the capabilities service for OSD plugins on the remote cluster to emit the capabilities that cluster has when it starts up and emit to the caller.

@ZilongX
Copy link
Collaborator Author

ZilongX commented Jul 5, 2024

This is cool. Thank you!

I haven't looked how this is set. Like is this set just one time when the datasource is added or is it anytime the datasource is selected?

Also do we plan on utilizing the capabilities service, for example link. For example, query assist there could be ML commons installed but doesn't have the chat feature.

We could use the capabilities service for OSD plugins on the remote cluster to emit the capabilities that cluster has when it starts up and emit to the caller.

It's onetime when the data source lists are loaded from saved objects. Basically this one to extend the fetch fields adding two more data source metadata in the returned list.

For leveraging of the capabilities service based on my current knowledge not yet, might be a promising one though and I'll check it out, but more it would be each individual plugin's choice preference.

@ZilongX ZilongX merged commit 901e39f into opensearch-project:main Jul 5, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 5, 2024
… installed plugins in MDS data source viewer returns (#7172)

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in MDS data source viewer returns

Signed-off-by: Zilong Xia <zilongx@amazon.com>

* Changeset file for PR #7172 created/updated

---------

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 901e39f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ZilongX pushed a commit that referenced this pull request Jul 5, 2024
… installed plugins in MDS data source viewer returns (#7172) (#7184)

* [Multiple Datasource][Version Decoupling] Add data source version and installed plugins in MDS data source viewer returns



* Changeset file for PR #7172 created/updated

---------



(cherry picked from commit 901e39f)

Signed-off-by: Zilong Xia <zilongx@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants