Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(queryEnhancements): fix dataSource.id reference to enable tests #7272

Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix(queryEnhancements): fix dataSource.id reference to enable tests #7272

merged 3 commits into from
Jul 23, 2024

Conversation

joshuali925
Copy link
Member

Description

  • fix dataSource.id references
  • enable tests
  • remove override of RequestHandlerContext as it's impacting other references in core
    • this causes things like context.query_assist.configPromise to be an error on type level. not sure what's the best solution

Issues Resolved

#7212 (comment)
#7212 (comment)

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@joshuali925
fix(queryEnhancements): fix dataSource.id reference to enable tests
b0f43d1 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 mentioned this pull request Jul 17, 2024
Merged
7 tasks
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (5ee9b69) to head (507c6c2).
Report is 273 commits behind head on main.

Files with missing lines Patch % Lines
...ublic/query_assist/components/query_assist_bar.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7272      +/-   ##
==========================================
+ Coverage   63.98%   64.03%   +0.05%     
==========================================
  Files        3598     3598              
  Lines       78322    78322              
  Branches    12352    12352              
==========================================
+ Hits        50111    50155      +44     
+ Misses      25189    25139      -50     
- Partials     3022     3028       +6
Flag Coverage Δ
Linux_1 31.08% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 41.29% <ø> (-0.01%) ⬇️
Linux_4 31.59% <50.00%> (+0.07%) ⬆️
Windows_1 31.12% <ø> (+0.02%) ⬆️
Windows_2 55.53% <ø> (ø)
Windows_3 41.29% <ø> (ø)
Windows_4 31.59% <50.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kavilla
kavilla approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you!

@kavilla
Copy link
Member

kavilla commented Jul 17, 2024

i think test failure unrelated to this PR

@ashwin-pc ashwin-pc merged commit c8496f8 into opensearch-project:main Jul 23, 2024
65 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@github-actions @kavilla @ruanyl
fix(queryEnhancements): fix dataSource.id reference to enable tests (#…
beb8198 
…7272)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit c8496f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 23, 2024
Merged
ananzh pushed a commit that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions
@kavilla @ruanyl
fix(queryEnhancements): fix dataSource.id reference to enable tests (#…
a53186b 
…7272) (#7406)

(cherry picked from commit c8496f8)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions
@kavilla @ruanyl @ananzh
fix(queryEnhancements): fix dataSource.id reference to enable tests (o…
1ff5401 
…pensearch-project#7272) (opensearch-project#7406)

(cherry picked from commit c8496f8)

Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
@ananzh ananzh mentioned this pull request Jul 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba