-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Navigation-next] Enable landing page for settings and data administration #7282
Merged
SuZhou-Joe
merged 11 commits into
opensearch-project:main
from
SuZhou-Joe:feature/landing-page
Jul 19, 2024
Merged
[Navigation-next] Enable landing page for settings and data administration #7282
SuZhou-Joe
merged 11 commits into
opensearch-project:main
from
SuZhou-Joe:feature/landing-page
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
July 17, 2024 08:36
opensearch-changeset-bot bot
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Jul 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7282 +/- ##
=======================================
Coverage 67.50% 67.50%
=======================================
Files 3501 3503 +2
Lines 69343 69376 +33
Branches 11305 11314 +9
=======================================
+ Hits 46808 46835 +27
- Misses 19779 19783 +4
- Partials 2756 2758 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
reviewed
Jul 17, 2024
src/plugins/management/public/components/feature_cards/feature_cards.tsx
Show resolved
Hide resolved
wanglam
approved these changes
Jul 17, 2024
Hailong-am
approved these changes
Jul 17, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
feature/landing-page
branch
from
July 18, 2024 08:29
8506b42
to
caef5dd
Compare
Pulling the latest main and re-running failed checks |
BionIT
approved these changes
Jul 19, 2024
ruanyl
approved these changes
Jul 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ation (#7282) * feat: enable landing page for settings and setup Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: enable landing page for settings and setup Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add page header Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7236 created/updated * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add landing page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7282 created/updated * feat: add landing page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit e44bd7e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ation (#7282) (#7312) * feat: enable landing page for settings and setup * feat: enable landing page for settings and setup * feat: add page header * Changeset file for PR #7236 created/updated * feat: update * feat: add landing page * Changeset file for PR #7282 created/updated * feat: add landing page * feat: optimize code --------- (cherry picked from commit e44bd7e) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly introduces 2 landing pages for 2 system nav group:
Issues Resolved
closes #7283
Screenshot
Data administration landing page
Settings and setup landing page
Testing the changes
http://localhost:5601/app/settings_landing
, you should see landing page for settings and setup.http://localhost:5601/app/data_administration_landing
, you should see landing page for data administration.Changelog
Check List
yarn test:jest
yarn test:jest_integration