-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support PPL in vega visualization #7285
feat: support PPL in vega visualization #7285
Conversation
This commit add PPL support in Vega visualization, it rely on query enhancement plugin to search with PPL Vega visualization UI changes is out of the scope, will add UI changes in separate commits Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
2 similar comments
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7285 +/- ##
=======================================
Coverage 67.53% 67.53%
=======================================
Files 3504 3505 +1
Lines 69407 69427 +20
Branches 11324 11328 +4
=======================================
+ Hits 46872 46886 +14
- Misses 19775 19779 +4
- Partials 2760 2762 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -62,7 +62,7 @@ export function registerSearchRoute( | |||
try { | |||
const { withLongNumeralsSupport, ...response } = await selfStart.search.search( | |||
context, | |||
{ ...searchRequest, id }, | |||
{ ...searchRequest, id, rawRequest: request }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wouldn't update this. when it's ppl, the whole request should be passed as long as you just send it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean we check the strategy
here, and when it's ppl
, we send the whole request instead of request.body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client.asScoped(request)
we call in search strategy requires the http request object, currently I see no better way to get it unless pass it explicitly.
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be possible to put like a parsers map in the search service? ideally. all non-out of the box experience is encapsulated within the query enhancements. so the parsers service can host the parser and take in a search strategy id. then in query enhancements we register the ppl
avoids having to re-write shared logic too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, let's explore the reusability, especially with considering the vis builder+vega, but that requires to clarify the requirement from both technical and design perspective, I'll leave it for future iteration, this PR is just the first step to add ppl support in vega. For now, I'll keep the scope as small as possible :)
* feat: support PPL in vega visualization This commit add PPL support in Vega visualization, it rely on query enhancement plugin to search with PPL Vega visualization UI changes is out of the scope, will add UI changes in separate commits Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 0af4b04) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7285-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0af4b04cd2f1ab90207eb84a91d96088231a4664
# Push it to GitHub
git push --set-upstream origin backport/backport-7285-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16 Then, create a pull request where the |
* feat: support PPL in vega visualization This commit add PPL support in Vega visualization, it rely on query enhancement plugin to search with PPL Vega visualization UI changes is out of the scope, will add UI changes in separate commits --------- (cherry picked from commit 0af4b04) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* feat: support PPL in vega visualization This commit add PPL support in Vega visualization, it rely on query enhancement plugin to search with PPL Vega visualization UI changes is out of the scope, will add UI changes in separate commits Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 0af4b04) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: support PPL in vega visualization This commit add PPL support in Vega visualization, it rely on query enhancement plugin to search with PPL Vega visualization UI changes is out of the scope, will add UI changes in separate commits --------- (cherry picked from commit 0af4b04) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This commit add PPL support in Vega visualization, it rely on query enhancement plugin to support search with PPL
Vega visualization UI changes is out of the scope of this PR, will add UI changes in separate commits
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration