[Discover-next] remove plugin config toggle for data enhancements #7291

kavilla · 2024-07-17T19:07:15Z

Description

Remove the data config toggle for enhancements and rely on the UI settings for being enabled. Also removes
the readonly UI setting that was previously added to prevent confusion unless users knew what they were using.

Issues Followup

#7212

Changelog

deprecate: Remove data enhancements config and readonly flag. Removes dead url link,

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Remove the data config toggle for enhancements and rely on the UI settings for being enabled. Issue Followup: opensearch-project#7212 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

github-actions · 2024-07-17T19:08:11Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-07-17T19:23:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (6d6ffaa) to head (1fa240a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7291      +/-   ##
==========================================
+ Coverage   67.32%   67.34%   +0.01%     
==========================================
  Files        3500     3500              
  Lines       69232    69231       -1     
  Branches    11282    11282              
==========================================
+ Hits        46613    46624      +11     
+ Misses      19893    19881      -12     
  Partials     2726     2726

Flag	Coverage Δ
Linux_1	`33.25% <100.00%> (-0.01%)`	⬇️
Linux_2	`55.30% <ø> (ø)`
Linux_3	`45.27% <100.00%> (+<0.01%)`	⬆️
Linux_4	`34.70% <100.00%> (-0.01%)`	⬇️
Windows_1	`33.30% <100.00%> (+0.02%)`	⬆️
Windows_2	`55.25% <ø> (ø)`
Windows_3	`45.28% <100.00%> (-0.01%)`	⬇️
Windows_4	`34.70% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

ashwin-pc · 2024-07-17T20:04:03Z

src/plugins/data/public/ui/settings/settings.ts

@@ -35,7 +35,7 @@ export class Settings {
    private readonly queryEnhancements: Map<string, QueryEnhancement>,
    private readonly queryEditorExtensionMap: Record<string, QueryEditorExtensionConfig>
  ) {
-    this.isEnabled = this.config.enabled;
+    this.isEnabled = true;


Why is this always true?

ah that actually makes sense not to be true good catch.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

…Search-Dashboards-1 into kavilla/enhancements-toggle

) * [Discover-next] remove plugin config toggle for data enhancements Remove the data config toggle for enhancements and rely on the UI settings for being enabled. Issue Followup: #7212 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix url Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * remove read only flag Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR #7291 created/updated * set default to false Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 5761207) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

) (#7293) * [Discover-next] remove plugin config toggle for data enhancements Remove the data config toggle for enhancements and rely on the UI settings for being enabled. (cherry picked from commit 5761207) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ensearch-project#7291) (opensearch-project#7293) * [Discover-next] remove plugin config toggle for data enhancements Remove the data config toggle for enhancements and rely on the UI settings for being enabled. (cherry picked from commit 5761207) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

) (#7293) (#7408) * [Discover-next] remove plugin config toggle for data enhancements Remove the data config toggle for enhancements and rely on the UI settings for being enabled. (cherry picked from commit 5761207) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ensearch-project#7291) (opensearch-project#7293) * [Discover-next] remove plugin config toggle for data enhancements Remove the data config toggle for enhancements and rely on the UI settings for being enabled. (cherry picked from commit 5761207) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ensearch-project#7291) (opensearch-project#7293) (opensearch-project#7408) * [Discover-next] remove plugin config toggle for data enhancements Remove the data config toggle for enhancements and rely on the UI settings for being enabled. (cherry picked from commit 5761207) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

[Discover-next] remove plugin config toggle for data enhancements

5240b44

Remove the data config toggle for enhancements and rely on the UI settings for being enabled. Issue Followup: opensearch-project#7212 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla requested review from ananzh, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27 and virajsanghvi as code owners July 17, 2024 19:07

github-actions bot added the distinguished-contributor label Jul 17, 2024

github-actions bot added the failed changeset label Jul 17, 2024

fix url

87ccfee

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

ashwin-pc previously approved these changes Jul 17, 2024

View reviewed changes

remove read only flag

749d6f8

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla dismissed ashwin-pc’s stale review via 749d6f8 July 17, 2024 19:51

kavilla removed the failed changeset label Jul 17, 2024

kavilla added backport 2.x v2.16.0 labels Jul 17, 2024

Changeset file for PR opensearch-project#7291 created/updated

ce1fcf8

kavilla requested a review from ashwin-pc July 17, 2024 19:56

ashwin-pc reviewed Jul 17, 2024

View reviewed changes

kavilla added 2 commits July 17, 2024 22:49

set default to false

9181833

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Merge branch 'kavilla/enhancements-toggle' of github.com:kavilla/Open…

1fa240a

…Search-Dashboards-1 into kavilla/enhancements-toggle

AMoo-Miki approved these changes Jul 18, 2024

View reviewed changes

ashwin-pc approved these changes Jul 18, 2024

View reviewed changes

ashwin-pc merged commit 5761207 into opensearch-project:main Jul 18, 2024
67 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 18, 2024

[Backport 2.x] [Discover-next] remove plugin config toggle for data enhancements #7293

Merged

ashwin-pc mentioned this pull request Jul 22, 2024

[RELEASE] Release version 2.16.0 opensearch-project/opensearch-build#4771

Closed

74 tasks

ananzh mentioned this pull request Jul 24, 2024

Missing backports from current 2.x to 2.16 #7466

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover-next] remove plugin config toggle for data enhancements #7291

[Discover-next] remove plugin config toggle for data enhancements #7291

kavilla commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024

codecov bot commented Jul 17, 2024 •

edited

Loading

ashwin-pc Jul 17, 2024

kavilla Jul 17, 2024

[Discover-next] remove plugin config toggle for data enhancements #7291

[Discover-next] remove plugin config toggle for data enhancements #7291

Conversation

kavilla commented Jul 17, 2024 • edited Loading

Description

Issues Followup

Changelog

Check List

github-actions bot commented Jul 17, 2024

❌ Empty Changelog Section

codecov bot commented Jul 17, 2024 • edited Loading

Codecov Report

ashwin-pc Jul 17, 2024

Choose a reason for hiding this comment

kavilla Jul 17, 2024

Choose a reason for hiding this comment

kavilla commented Jul 17, 2024 •

edited

Loading

codecov bot commented Jul 17, 2024 •

edited

Loading