Disable input in edit data source when data_source.manageableBy is none #7307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7307 +/- ##
=======================================
Coverage 67.50% 67.50%
=======================================
Files 3501 3501
Lines 69343 69345 +2
Branches 11305 11307 +2
=======================================
+ Hits 46808 46812 +4
+ Misses 19779 19778 -1
+ Partials 2756 2755 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eemijuntunen
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
|
Rebased the branch |
Signed-off-by: Eemi Juntunen <eemijun@amazon.com>
Signed-off-by: Eemi Juntunen <eemijun@amazon.com>
Signed-off-by: Eemi Juntunen <eemijun@amazon.com>
Signed-off-by: Eemi Juntunen <eemijun@amazon.com>
zhyuanqi
added
backport 2.x
multiple datasource
zhyuanqi
approved these changes
Jul 18, 2024
BionIT
approved these changes
Jul 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…ne (#7307) * Disable input in edit data source when data_source.manageableBy is none Signed-off-by: Eemi Juntunen <eemijun@amazon.com> * Changeset file for PR #7307 created/updated * Removed unnecessary canManageDataSource check Signed-off-by: Eemi Juntunen <eemijun@amazon.com> * Fix lint issue Signed-off-by: Eemi Juntunen <eemijun@amazon.com> * Update snapshot Signed-off-by: Eemi Juntunen <eemijun@amazon.com> --------- Signed-off-by: Eemi Juntunen <eemijun@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ddc26fc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ne (#7307) (#7310) * Disable input in edit data source when data_source.manageableBy is none * Changeset file for PR #7307 created/updated * Removed unnecessary canManageDataSource check * Fix lint issue * Update snapshot --------- (cherry picked from commit ddc26fc) Signed-off-by: Eemi Juntunen <eemijun@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable the input fields on the edit data source form when data_source.manageableBy is set to none. For OpenSearch connections.
Screenshot
No Authentication - data_source.manageableBy: "none"
No Authentication - data_source.manageableBy: "all"
Username and Password Authentication - data_source.manageableBy: "none"
Username and Password Authentication - data_source.manageableBy: "all"
AWS Authentication - data_source.manageableBy: "none"
AWS Authentication - data_source.manageableBy: "all"
Testing the changes
data_source.manageableBy: "none"
Changelog
Check List
yarn test:jestyarn test:jest_integration