[Backport 2.x] [Workspace] use registered nav groups in workspace form #7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add registered use cases Signed-off-by: Lin Wang <wonglam@amazon.com> * Separate use case service and fix UTs Signed-off-by: Lin Wang <wonglam@amazon.com> * Add test case for workspace plugin Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix workspace unit tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #7221 created/updated * Remove workspaceConfigurableApp$ in component Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove no need workspaceConfigurableApps$ and add navGroupUpdater ut Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix type error Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove centered horizontal position Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix isDashboardAdmin in workspace creator unit tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix dynamic nav groups missing in workspace list Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit fceba91) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7317 +/- ##
==========================================
+ Coverage 67.93% 67.94% +0.01%
==========================================
Files 3455 3456 +1
Lines 68462 68494 +32
Branches 11150 11158 +8
==========================================
+ Hits 46510 46541 +31
+ Misses 19244 19240 -4
- Partials 2708 2713 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Jul 20, 2024
SuZhou-Joe
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fceba91 from #7221.