fix: Fix wrapping of labels in filter by type popover #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7327 +/- ##
=======================================
Coverage 67.69% 67.69%
=======================================
Files 3517 3517
Lines 69578 69578
Branches 11354 11354
=======================================
Hits 47100 47100
Misses 19692 19692
Partials 2786 2786
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
virajsanghvi
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
zhongnansu
approved these changes
Jul 20, 2024
ruanyl
approved these changes
Jul 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 21, 2024
* fix: Fix wrapping of labels in filter by type popover Signed-off-by: Viraj Sanghvi <virajs@amazon.com> * Changeset file for PR #7327 created/updated --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 376ead0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
virajsanghvi
pushed a commit
that referenced
this pull request
Jul 22, 2024
* fix: Fix wrapping of labels in filter by type popover --------- (cherry picked from commit 376ead0) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes wrapping of labels in filter by type popover in discover.
This was caused by the removal of a min-width in opensearch-project/oui#1280
Issues Resolved
N/A
Screenshot
Before:
After
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration