Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation] Update dev tools tab css for new left navigation #7328

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Jul 19, 2024

Description

As part of new left navigation Workbench would be moved to dev tools. To make this happen we have registered workbench based on the new nav condition. The css in devtools is making the tabs justify apart justify-content: space-between;. Removing this css is fixing the UI and keeping it as expected. This PR removes the unnecessary css on dev tools Tab.

Issues Resolved

Related Workbench PR: opensearch-project/dashboards-query-workbench#349

Screenshot

Before:
Screenshot 2024-07-19 at 3 14 04 PM

After:
Screenshot 2024-07-19 at 3 15 11 PM
Screenshot 2024-07-19 at 3 15 21 PM

Testing the changes

  1. Load dashboards core in local setup
  2. Add workbench plugin from main/2.x branch
  3. Add the feature flag for new nav.
  4. Move to dev tools and looks at the tabs spacing.

Changelog

  • fix: [Navigation] Update dev tools tab css for new left navigation

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7328.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@ps48
Copy link
Member Author

ps48 commented Jul 19, 2024

@mengweieric @SuZhou-Joe Can you please help review the PR and backport this to 2.x? I am a first time contributor to OSD core. Would be grateful to understand if I am missing something here.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (54cdf23) to head (44d3210).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7328      +/-   ##
==========================================
- Coverage   67.53%   67.53%   -0.01%     
==========================================
  Files        3504     3504              
  Lines       69407    69407              
  Branches    11324    11324              
==========================================
- Hits        46874    46872       -2     
- Misses      19773    19775       +2     
  Partials     2760     2760              
Flag Coverage Δ
Linux_1 33.15% <ø> (ø)
Linux_2 55.46% <ø> (ø)
Linux_3 43.05% <ø> (ø)
Linux_4 34.76% <ø> (ø)
Windows_1 33.17% <ø> (ø)
Windows_2 55.41% <ø> (ø)
Windows_3 43.06% <ø> (ø)
Windows_4 34.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe
Copy link
Member

Could you please post a screenshot of how the devTools will look like without query workbench plugin installed under your change?

@mengweieric
Copy link
Collaborator

Could we check if the failing CI is relevant?

@ps48
Copy link
Member Author

ps48 commented Jul 20, 2024

Could you please post a screenshot of how the devTools will look like without query workbench plugin installed under your change?

Hi @SuZhou-Joe, This is how dev tool looks like without workbench
Screenshot 2024-07-20 at 8 02 05 AM

@SuZhou-Joe SuZhou-Joe merged commit 4c61906 into opensearch-project:main Jul 20, 2024
68 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 20, 2024
* update dev tools tab css

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Changeset file for PR #7328 created/updated

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 4c61906)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 21, 2024
…#7334)

* update dev tools tab css



* Changeset file for PR #7328 created/updated

---------



(cherry picked from commit 4c61906)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants