-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress data source selector on management's data sources page #7329
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7329 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 3521 3521
Lines 69777 69777
Branches 11390 11390
=======================================
+ Hits 47244 47246 +2
+ Misses 19732 19730 -2
Partials 2801 2801
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3eab0b9
to
fa573c3
Compare
@AMoo-Miki You may need to update the failed snapshot tests |
fa573c3
to
67f089d
Compare
67f089d
to
fdddfbd
Compare
* management's data sources page * dev tools * home * query enhancements * saved object mgmt * time series Signed-off-by: Miki <miki@amazon.com>
fdddfbd
to
c2eb135
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7329-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3526f96f5889227fd79f3e671b3e3507a1a547d1
# Push it to GitHub
git push --set-upstream origin backport/backport-7329-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* management's data sources page * dev tools * home * query enhancements * saved object mgmt * time series Signed-off-by: Miki <miki@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 3526f96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* management's data sources page * dev tools * home * query enhancements * saved object mgmt * time series Signed-off-by: Miki <miki@amazon.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 3526f96) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* management's data sources page * dev tools * home * query enhancements * saved object mgmt * time series (cherry picked from commit 3526f96) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
…h-project#7412) * management's data sources page * dev tools * home * query enhancements * saved object mgmt * time series (cherry picked from commit 3526f96) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
I see a 2px height diff which is problem with the
DataSourceSelector
component.Changelog
Check List
yarn test:jest
yarn test:jest_integration