-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HomePage] Add home page static list card #7351
Conversation
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
import { EuiCard, EuiLink, EuiListGroup } from '@elastic/eui'; | ||
|
||
export const LEARN_OPENSEARCH_CONFIG = { | ||
title: 'Learn Opensearch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we at least wrap it with i18n?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7351 +/- ##
==========================================
- Coverage 67.70% 67.70% -0.01%
==========================================
Files 3519 3520 +1
Lines 69685 69700 +15
Branches 11374 11376 +2
==========================================
+ Hits 47183 47189 +6
- Misses 19708 19716 +8
- Partials 2794 2795 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
) : null | ||
} | ||
> | ||
<EuiListGroup listItems={config.list} color="text" size="s" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If description
is needed, I think we should use DescriptionList component https://oui.opensearch.org/1.8/#/display/description-list
Signed-off-by: tygao <tygao@amazon.com>
* feat: add home static list card Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #7351 created/updated * update link property Signed-off-by: tygao <tygao@amazon.com> * add i18n and description Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e64de15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Have added a comment to confirm with designers. |
* feat: add home static list card * Changeset file for PR #7351 created/updated * update link property * add i18n and description --------- (cherry picked from commit e64de15) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* feat: add home static list card * Changeset file for PR #7351 created/updated * update link property * add i18n and description --------- (cherry picked from commit e64de15) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 6685bce) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat: add home static list card * Changeset file for PR #7351 created/updated * update link property * add i18n and description --------- (cherry picked from commit e64de15) (cherry picked from commit 6685bce) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Add home page static list card
Screenshot
Testing the changes
Enable new homepage and go to homepage.
Changelog
Check List
yarn test:jest
yarn test:jest_integration