-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Hide create workspace button for non dashboard admin #7357
[Workspace]Hide create workspace button for non dashboard admin #7357
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7357 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 3520 3520
Lines 69700 69704 +4
Branches 11376 11378 +2
=======================================
+ Hits 47189 47193 +4
Misses 19716 19716
Partials 2795 2795
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change lgtm, cypress test failure seems unrelated, but please validate
The failed cypress test is unrelated, merging now. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7357-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c1dd5c109f01faec151990a8864fcee80d218699
# Push it to GitHub
git push --set-upstream origin backport/backport-7357-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…search-project#7357) * Hide create workspace for non dashboard admin Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#7357 created/updated * Add more cases and update snapshot Signed-off-by: Lin Wang <wonglam@amazon.com> * Update match rule Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
… (#7382) * Hide create workspace for non dashboard admin * Changeset file for PR #7357 created/updated * Add more cases and update snapshot * Update match rule --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
… (#7382) * Hide create workspace for non dashboard admin * Changeset file for PR #7357 created/updated * Add more cases and update snapshot * Update match rule --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1f5f461) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… (#7382) (#7390) * Hide create workspace for non dashboard admin * Changeset file for PR #7357 created/updated * Add more cases and update snapshot * Update match rule --------- (cherry picked from commit 1f5f461) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Only dashboard admin can create workspace, this PR hide create workspace entry in workspace menu and workspace list.
Issues Resolved
#7358
Screenshot
Workspace Menu
Workspace list
Testing the changes
yarn osd bootstrap
config/opensearch_dashboards.yml
yarn start --no-base-path
opensearchDashboards.dashboardAdmin.users
inconfig/opensearch_dashboards.yml
Changelog
Check List
yarn test:jest
yarn test:jest_integration