Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. #7439

Closed
wants to merge 5 commits into from
Closed

[Backport 2.16] [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. #7439

wants to merge 5 commits into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Jul 24, 2024 •
edited by SuZhou-Joe
Loading

Backport 3f78c94 from #7401.

@github-actions @opensearch-changeset-bot @ZilongX
[navigation-next]fix: breadcrumb issue found in data source managemen…
0f15edd 
…t and other similar cases. (#7401) (#7437)

* feat: add scoped breadcrumbs

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* feat: move data source management register logic up a little bit

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: revert the home related change

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: overview error in all use case when workspace is enabled

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* fix: update snapshot

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7401 created/updated

* fix: hide nav groups that should be displayed

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: hide expand icon in left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
(cherry picked from commit 3f78c94)
(cherry picked from commit 1e6579b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added the autocut Skip the changelog verification check on backports label Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.84%. Comparing base (23d2c5c) to head (f3ac457).
Report is 1 commits behind head on 2.16.

Files Patch % Lines
...ic/react_router_navigate/react_router_navigate.tsx 60.00% 1 Missing and 1 partial ⚠️
src/plugins/workspace/public/plugin.ts 0.00% 1 Missing and 1 partial ⚠️
src/core/public/chrome/ui/header/header.tsx 83.33% 1 Missing ⚠️
src/plugins/advanced_settings/public/plugin.ts 0.00% 1 Missing ⚠️
...rc/plugins/data_source_management/public/plugin.ts 66.66% 1 Missing ⚠️
.../plugins/index_pattern_management/public/plugin.ts 0.00% 1 Missing ⚠️
.../plugins/saved_objects_management/public/plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.16    #7439      +/-   ##
==========================================
- Coverage   67.87%   67.84%   -0.03%     
==========================================
  Files        3589     3589              
  Lines       72326    72364      +38     
  Branches    11838    11848      +10     
==========================================
+ Hits        49088    49095       +7     
- Misses      20246    20272      +26     
- Partials     2992     2997       +5
Flag Coverage Δ
Linux_1 33.49% <5.88%> (-0.01%) ⬇️
Linux_2 55.67% <88.88%> (+<0.01%) ⬆️
Linux_3 44.43% <15.00%> (-0.03%) ⬇️
Linux_4 34.19% <15.00%> (-0.01%) ⬇️
Windows_1 33.51% <5.88%> (-0.01%) ⬇️
Windows_2 55.62% <88.88%> (+<0.01%) ⬆️
Windows_3 ?
Windows_4 34.20% <15.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Jul 24, 2024
View reviewed changes
@SuZhou-Joe
feat: update snapshot
985a73a 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: update snapshot
a26dcef 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
fix: functional test error
94ac62a 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe
feat: change the order of createRef
f7a4852 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@SuZhou-Joe SuZhou-Joe force-pushed the backport/backport-7437-to-2.16 branch 2 times, most recently from f3ac457 to f7a4852 Compare July 24, 2024 17:49
@SuZhou-Joe
Copy link
Member

rely on the merge of #7366

@ananzh ananzh deleted the branch 2.16 July 24, 2024 23:56
@ananzh ananzh closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports failed changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @ruanyl @ananzh