Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump browserslist from 4.22.1 to 4.23.2 to resolve integration test error #7444

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 24, 2024

Description

Bump browserslist to fix

FAIL  packages/osd-plugin-helpers/src/integration_tests/build.test.ts (19.15 s)
  ● builds a generated plugin into a viable archive

    expect(received).toMatchInlineSnapshot(snapshot)

    Snapshot name: `builds a generated plugin into a viable archive 2`

    - Snapshot  - 3
    + Received  + 9

      " info deleting the build and target directories
       info running @osd/optimizer
       │ info initialized, 0 bundles cached
       │ info starting worker [1 bundle]
    -  │ succ 1 bundles compiled successfully after <time>
    -  info copying assets from `public/assets` to build
    -  info copying server source into the build and converting with babel
    +  │ warn worker stderr Browserslist: caniuse-lite is outdated. Please run:
    +  │ warn worker stderr   npx update-browserslist-db@latest
    +  │ warn worker stderr   Why you should do it regularly: 
https://github.com/browserslist/update-db#readme
    +  │ succ 1 bundles compiled successfully after <time>
    +  info copying assets from `public/assets` to build
    +  info copying server source into the build and converting with babel
    + Browserslist: caniuse-lite is outdated. Please run:
    +   npx update-browserslist-db@latest
    +   Why you should do it regularly: 
https://github.com/browserslist/update-db#readme
       info running yarn to install dependencies
       info compressing plugin into [fooTestPlugin-1.0.0.zip]
       info cleaning up compression temporary artifacts"

       97 |   );
       98 |
    >  99 |   expect(buildProc.all).toMatchInlineSnapshot(`
          |                         ^
      100 |     " info deleting the build and target directories
      101 |      info running @osd/optimizer
      102 |      │ info initialized, 0 bundles cached

      at Object.<anonymous> (packages/osd-plugin-helpers/src/integration_tests/build.test.ts:99:25)

  ● builds a non-semver generated plugin into a viable archive

    expect(received).toMatchInlineSnapshot(snapshot)

    Snapshot name: `builds a non-semver generated plugin into a viable archive 2`

    - Snapshot  - 3
    + Received  + 9

      " info deleting the build and target directories
       info running @osd/optimizer
       │ info initialized, 0 bundles cached
       │ info starting worker [1 bundle]
    -  │ succ 1 bundles compiled successfully after <time>
    -  info copying assets from `public/assets` to build
    -  info copying server source into the build and converting with babel
    +  │ warn worker stderr Browserslist: caniuse-lite is outdated. Please run:
    +  │ warn worker stderr   npx update-browserslist-db@latest
    +  │ warn worker stderr   Why you should do it regularly: 
https://github.com/browserslist/update-db#readme
    +  │ succ 1 bundles compiled successfully after <time>
    +  info copying assets from `public/assets` to build
    +  info copying server source into the build and converting with babel
    + Browserslist: caniuse-lite is outdated. Please run:
    +   npx update-browserslist-db@latest
    +   Why you should do it regularly: 
https://github.com/browserslist/update-db#readme
       info running yarn to install dependencies
       info compressing plugin into [fooTestPlugin-1.0.0.x.zip]
       info cleaning up compression temporary artifacts"

      185 |   );
      186 |
    > 187 |   expect(buildProc.all).toMatchInlineSnapshot(`
          |                         ^
      188 |     " info deleting the build and target directories
      189 |      info running @osd/optimizer
      190 |      │ info initialized, 0 bundles cached

      at Object.<anonymous> (packages/osd-plugin-helpers/src/integration_tests/build.test.ts:187:25)

Issues Resolved

NA

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Copy link
Contributor

❌ Invalid Additional Prefix With Skip Entry Option

If your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again.

@ananzh ananzh added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry maintenance backport 2.x labels Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.11%. Comparing base (906ef97) to head (eb8f267).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7444      +/-   ##
==========================================
- Coverage   64.13%   64.11%   -0.03%     
==========================================
  Files        3614     3614              
  Lines       78680    78690      +10     
  Branches    12432    12436       +4     
==========================================
- Hits        50463    50453      -10     
- Misses      25167    25184      +17     
- Partials     3050     3053       +3     
Flag Coverage Δ
Linux_1 30.90% <ø> (-0.01%) ⬇️
Linux_2 55.59% <ø> (+<0.01%) ⬆️
Linux_3 40.64% <ø> (-0.01%) ⬇️
Linux_4 31.77% <ø> (+<0.01%) ⬆️
Windows_1 ?
Windows_2 55.54% <ø> (+<0.01%) ⬆️
Windows_3 ?
Windows_4 31.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh merged commit f0a1307 into opensearch-project:main Jul 24, 2024
79 of 82 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7444-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f0a1307548d3ed0441ca66d9c2dd010b22b46809
# Push it to GitHub
git push --set-upstream origin backport/backport-7444-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7444-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7444-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f0a1307548d3ed0441ca66d9c2dd010b22b46809
# Push it to GitHub
git push --set-upstream origin backport/backport-7444-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7444-to-2.16.

ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
…olve integ test error

Backport PR:
opensearch-project#7444

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Jul 24, 2024
…solve integ test error

Backport PR
opensearch-project#7444

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 24, 2024
…olve integ test error (#7450)

Backport PR:
#7444

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh added a commit that referenced this pull request Jul 24, 2024
…solve integ test error (#7451)

Backport PR
#7444

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants