Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] Refactored src/cli/* #75

Merged
merged 2 commits into from
Mar 13, 2021
Merged

[Rename] Refactored src/cli/* #75

merged 2 commits into from
Mar 13, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni mihirsoni.123@gmail.com

Issue #, if available: #37

Description of changes: Refactored src/cli directory to comply with new name.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
src/cli/cli.js Outdated Show resolved Hide resolved
src/cli/cluster/cluster_manager.ts Show resolved Hide resolved
src/cli/repl/index.js Show resolved Hide resolved
src/cli/repl/index.js Show resolved Hide resolved
src/cli/repl/repl.test.js Show resolved Hide resolved
src/cli/repl/repl.test.js Show resolved Hide resolved
src/cli/cluster/worker.ts Outdated Show resolved Hide resolved
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@kavilla kavilla self-requested a review March 12, 2021 18:59
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, hopefully the APM stuff doesn't cause a lot of issues.

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit b6e9a05 into opensearch-project:dashboards Mar 13, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
* [Rename] Refactored src/cli/*

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/cli/*

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
* [Rename] Refactored src/cli/*

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>

* [Rename] accomodate PR review feedback

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 8, 2023
…oject#75)

* feat: add permission control section to workspace form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: update naming for convert acl

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update read / write to library_read / library_write

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 14, 2023
…oject#75)

* feat: add permission control section to workspace form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: update naming for convert acl

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update read / write to library_read / library_write

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 15, 2023
…oject#75)

* feat: add permission control section to workspace form

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: update naming for convert acl

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: update read / write to library_read / library_write

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants