Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update icon of recent items from OUI library to enable dark mode #7508

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix: update icon of recent items from OUI library to enable dark mode #7508

merged 2 commits into from
Jul 26, 2024

Conversation

raintygao
Copy link
Contributor

Description

Update icon of recent items from OUI library to enable dark mode.
Before we use svg code directly to render icon, however this icon would not be updated with dark mode. We will use a icon of OUI for now, and once replace in #7354

Screenshot

image
image

Testing the changes

Changelog

  • fix: Update icon of recent items from OUI library to enable dark mode

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@raintygao
fix: use icon from library to enable dark mode
b61f6d7 
Signed-off-by: tygao <tygao@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.11%. Comparing base (e24e535) to head (f1b4b1d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7508      +/-   ##
==========================================
- Coverage   64.13%   64.11%   -0.02%     
==========================================
  Files        3616     3615       -1     
  Lines       78759    78757       -2     
  Branches    12453    12453              
==========================================
- Hits        50511    50496      -15     
- Misses      25194    25206      +12     
- Partials     3054     3055       +1
Flag Coverage Δ
Linux_1 30.91% <ø> (-0.01%) ⬇️
Linux_2 55.59% <ø> (+<0.01%) ⬆️
Linux_3 40.63% <ø> (-0.02%) ⬇️
Linux_4 31.76% <ø> (-0.01%) ⬇️
Windows_1 30.92% <ø> (-0.03%) ⬇️
Windows_2 55.54% <ø> (+<0.01%) ⬆️
Windows_3 40.65% <ø> (-0.01%) ⬇️
Windows_4 31.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit fc1adfa into opensearch-project:main Jul 26, 2024
73 of 75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
@github-actions @opensearch-changeset-bot
fix: update icon of recent items from OUI library to enable dark mode (…
a50e3ad 
…#7508)

* fix: use icon from library to enable dark mode

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #7508 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit fc1adfa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 26, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2024
@github-actions @opensearch-changeset-bot
fix: update icon of recent items from OUI library to enable dark mode (…
9b7f979 
…#7508)

* fix: use icon from library to enable dark mode

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR #7508 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit fc1adfa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 26, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Jul 26, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
fix: update icon of recent items from OUI library to enable dark mode (…
cf487a7 
…#7508) (#7513)

* fix: use icon from library to enable dark mode



* Changeset file for PR #7508 created/updated

---------



(cherry picked from commit fc1adfa)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Jul 26, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
fix: update icon of recent items from OUI library to enable dark mode (…
e2e3f46 
…#7508) (#7514)

* fix: use icon from library to enable dark mode



* Changeset file for PR #7508 created/updated

---------



(cherry picked from commit fc1adfa)

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
paulstn pushed a commit to paulstn/OpenSearch-Dashboards that referenced this pull request Jul 26, 2024
@raintygao @opensearch-changeset-bot @paulstn
fix: update icon of recent items from OUI library to enable dark mode (…
d7cdf39 
…opensearch-project#7508)

* fix: use icon from library to enable dark mode

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#7508 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
@raintygao @opensearch-changeset-bot @Qxisylolo
fix: update icon of recent items from OUI library to enable dark mode (…
84b6a11 
…opensearch-project#7508)

* fix: use icon from library to enable dark mode

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#7508 created/updated

---------

Signed-off-by: tygao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.16 navigation seasoned-contributor v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raintygao @ruanyl @SuZhou-Joe