Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.16] fix: update icon of recent items from OUI library to enable dark mode #7514

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[Backport 2.16] fix: update icon of recent items from OUI library to enable dark mode #7514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7508.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Update icon of recent items from OUI library to enable dark mode ([#7508](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7508))
2 changes: 1 addition & 1 deletion src/core/public/chrome/ui/header/__snapshots__/recent_items.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions src/core/public/chrome/ui/header/recent_items.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import { WorkspaceObject } from '../../../workspace';
import { createRecentNavLink } from './nav_link';
import { HttpStart } from '../../../http';
import { ChromeNavLink } from '../../../';
// TODO: replace this icon once added to OUI https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7354
import { RecentItemsIcon } from './recent_items_icon';

export interface Props {
recentlyAccessed$: Rx.Observable<ChromeRecentlyAccessedHistoryItem[]>;
Expand Down Expand Up @@ -71,7 +69,8 @@ export const RecentItems = ({
}}
data-test-subj="recentItemsSectionButton"
>
<EuiIcon type={RecentItemsIcon} size="m" />
{/* TODO: replace this icon once there is a new icon added to OUI https://github.com/opensearch-project/OpenSearch-Dashboards/issues/7354 */}
<EuiIcon type="recentlyViewedApp" size="m" />
</EuiHeaderSectionItemButton>
}
isOpen={isPopoverOpen}
Expand Down
17 changes: 0 additions & 17 deletions src/core/public/chrome/ui/header/recent_items_icon.tsx
View file
Open in desktop

This file was deleted.

Loading