Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look&Feel] Discover and Query Management fix #7530

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

danieldong51
Copy link
Contributor

@danieldong51 danieldong51 commented Jul 26, 2024

Description

This PR fixes 4 things:

  • For the Saved Query Management Button:
  • For the Discover Sidebar:
    • Changes Discover sidebar add and remove field icons from EuiSmallButtonIcon to EuiButtonIcon with size='xs', which fixes the spacing issue in the sidebar
  • For the Visualization Legend Button:
    • Change positioning attributes on Visualization Legend Button from the button to the tooltip anchor, to fix a bug where the tooltip was separated from the button.

Screenshot

Saved Query Management Button

Note the change in alignment of the saved query management icon.

Scope Before (v7Light) After (v7Light) Before (v8dark) After (v8dark)
Discover, query enhancements off Discover, Query Enhance Off v7 Light Before Discover, Query Enhance Off v7 Light Post Discover, Query Enhance Off v8 Dark Before Discover, Query Enhance Off v8 Dark Post
Discover, query enhancements on Discover v7 Light Before Discover v7 Light Post Discover v8 Dark Before Discover v8 Dark Post
Dashboards Dashboard v7 Light Before Dashboard v7 Light Post Dashboard v8 Dark Before Dashboard v8 Dark Post

Discover: Sidebar

Note the change in spacing of the list items in the sidebar.

Before (v7Light) After (v7Light) Before (v8dark) After (v8dark)
Sidebar v7 Light Before Sidebar v7 Light Post Sidebar v8 Dark Before Sidebar v8 Dark Post

Toggle Legend

Note the change in location of the tooltip.

Scope Before (v8dark) After (v8dark)
Dashboards Toggle Legend Dashboards v8 Dark Before Toggle Legend Dashboards v8 Dark Post
Visualization Page Toggle Legend Vis v8 Dark Before Toggle Legend Vis v8 Dark Post

Changelog

  • refactor: [Look&Feel] Discover and Query Management fix

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

opensearch-changeset-bot bot added a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.65%. Comparing base (2d8c743) to head (761a7d2).
Report is 245 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7530      +/-   ##
==========================================
- Coverage   63.65%   63.65%   -0.01%     
==========================================
  Files        3629     3629              
  Lines       79519    79519              
  Branches    12602    12602              
==========================================
- Hits        50618    50616       -2     
- Misses      25834    25835       +1     
- Partials     3067     3068       +1     
Flag Coverage Δ
Linux_1 30.76% <ø> (ø)
Linux_2 55.58% <ø> (ø)
Linux_3 40.24% <100.00%> (+<0.01%) ⬆️
Linux_4 31.57% <ø> (ø)
Windows_1 30.78% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.24% <100.00%> (ø)
Windows_4 31.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Jul 28, 2024
kavilla
kavilla previously approved these changes Jul 28, 2024
danieldong51 and others added 6 commits July 29, 2024 10:30
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
(cherry picked from commit 5dbce93)
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - test failures appear to be due to flakey tests

@zhongnansu zhongnansu merged commit 7073999 into opensearch-project:main Jul 29, 2024
65 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
* Removed downArrow icon and tooltip

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changed icons from smallIcons to xs

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Added browser tooltip back

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changed remove field icon size to xs

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changeset file for PR #7530 created/updated

* Changed positioning attributes to ToolTip Anchor

Signed-off-by: Dan Dong <danieldong51@gmail.com>
(cherry picked from commit 5dbce93)

* Updated snapshot testing

Signed-off-by: Dan Dong <danieldong51@gmail.com>

---------

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7073999)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7530-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 70739998513017bb3e4d808bf30da9258a3e87a9
# Push it to GitHub
git push --set-upstream origin backport/backport-7530-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7530-to-2.16.

virajsanghvi pushed a commit that referenced this pull request Jul 30, 2024
* Removed downArrow icon and tooltip
* Changed icons from smallIcons to xs
* Added browser tooltip back
* Changed remove field icon size to xs
* Changed positioning attributes to ToolTip Anchor

---------

(cherry picked from commit 7073999)

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
* Removed downArrow icon and tooltip

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changed icons from smallIcons to xs

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Added browser tooltip back

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changed remove field icon size to xs

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changeset file for PR opensearch-project#7530 created/updated

* Changed positioning attributes to ToolTip Anchor

Signed-off-by: Dan Dong <danieldong51@gmail.com>
(cherry picked from commit 5dbce93)

* Updated snapshot testing

Signed-off-by: Dan Dong <danieldong51@gmail.com>

---------

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants