-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Look&Feel] Discover and Query Management fix #7530
Conversation
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7530 +/- ##
==========================================
- Coverage 63.65% 63.65% -0.01%
==========================================
Files 3629 3629
Lines 79519 79519
Branches 12602 12602
==========================================
- Hits 50618 50616 -2
- Misses 25834 25835 +1
- Partials 3067 3068 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> (cherry picked from commit 5dbce93)
Signed-off-by: Dan Dong <danieldong51@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - test failures appear to be due to flakey tests
* Removed downArrow icon and tooltip Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changed icons from smallIcons to xs Signed-off-by: Dan Dong <danieldong51@gmail.com> * Added browser tooltip back Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changed remove field icon size to xs Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changeset file for PR #7530 created/updated * Changed positioning attributes to ToolTip Anchor Signed-off-by: Dan Dong <danieldong51@gmail.com> (cherry picked from commit 5dbce93) * Updated snapshot testing Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 7073999) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7530-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 70739998513017bb3e4d808bf30da9258a3e87a9
# Push it to GitHub
git push --set-upstream origin backport/backport-7530-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16 Then, create a pull request where the |
* Removed downArrow icon and tooltip * Changed icons from smallIcons to xs * Added browser tooltip back * Changed remove field icon size to xs * Changed positioning attributes to ToolTip Anchor --------- (cherry picked from commit 7073999) Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* Removed downArrow icon and tooltip Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changed icons from smallIcons to xs Signed-off-by: Dan Dong <danieldong51@gmail.com> * Added browser tooltip back Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changed remove field icon size to xs Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changeset file for PR opensearch-project#7530 created/updated * Changed positioning attributes to ToolTip Anchor Signed-off-by: Dan Dong <danieldong51@gmail.com> (cherry picked from commit 5dbce93) * Updated snapshot testing Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR fixes 4 things:
Screenshot
Saved Query Management Button
Note the change in alignment of the saved query management icon.
Discover: Sidebar
Note the change in spacing of the list items in the sidebar.
Toggle Legend
Note the change in location of the tooltip.
Changelog
Check List
yarn test:jest
yarn test:jest_integration