-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix babel error #7541
Fix babel error #7541
Conversation
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 7541.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 7541.yml under folder changelogs/fragments to complete this PR. File still missing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7541 +/- ##
===========================================
+ Coverage 40.00% 64.21% +24.21%
===========================================
Files 11 3614 +3603
Lines 170 78750 +78580
Branches 0 12446 +12446
===========================================
+ Hits 68 50567 +50499
- Misses 102 25132 +25030
- Partials 0 3051 +3051
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
"@babel/code-frame@^7.24.7": | ||
version "7.24.7" | ||
resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.24.7.tgz#882fd9e09e8ee324e496bd040401c6f046ef4465" | ||
integrity sha512-BcYH1CVJBO9tvyIZ2jVeXgSIMvGZ2FDRvDdOIVQyuklNKSsx+eppDEBq/g47Ayw+RqNFE+URvOShmf+f/qwAlA== | ||
dependencies: | ||
"@babel/highlight" "^7.24.7" | ||
picocolors "^1.0.0" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been combined with the block above. Why didn't the resolution do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they shouldn't be combined, 7.22.13 and 7.24.7 are not the same version
OpenSearch-Dashboards/yarn.lock
Lines 169 to 170 in 9431e11
"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.10.4", "@babel/code-frame@^7.12.13", "@babel/code-frame@^7.22.13": | |
version "7.22.13" |
"@babel/generator@^7.25.0": | ||
version "7.25.0" | ||
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.25.0.tgz#f858ddfa984350bc3d3b7f125073c9af6988f18e" | ||
integrity sha512-3LEEcj3PVW8pW2R1SR1M89g/qrYk/m/mB/tLqn7dn4sbBUQyTqnlod+II2U4dqiGtUmkcnAmkMDralTFZttRiw== | ||
dependencies: | ||
"@babel/types" "^7.25.0" | ||
"@jridgewell/gen-mapping" "^0.3.5" | ||
"@jridgewell/trace-mapping" "^0.3.25" | ||
jsesc "^2.5.1" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this... It should have been combined with the block above. Why is it not?
in fact, some other changes should have been combined as well. I would recommend removing the duplicate definitions and doing a bootstrap to fix this.
* fix babel error Signed-off-by: Eric <menwe@amazon.com> * movetesting library to where it was Signed-off-by: Eric <menwe@amazon.com> * Changeset file for PR #7541 created/updated --------- Signed-off-by: Eric <menwe@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit bcb8355) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix babel error * movetesting library to where it was * Changeset file for PR #7541 created/updated --------- (cherry picked from commit bcb8355) Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Fix bootstrapping error due to babel error. Changed necessary dependencies versions to compatible ones specific to 2.x. This change is specifically for 2.x, these dependencies are compatible on main.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration