Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babel error #7541

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Fix babel error #7541

merged 3 commits into from
Jul 29, 2024

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Jul 27, 2024

Description

Fix bootstrapping error due to babel error. Changed necessary dependencies versions to compatible ones specific to 2.x. This change is specifically for 2.x, these dependencies are compatible on main.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Fix babel error

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7541.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 7541.yml under folder changelogs/fragments to complete this PR. File still missing.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.21%. Comparing base (eb99c5c) to head (9431e11).

Additional details and impacted files
@@             Coverage Diff             @@
##              2.x    #7541       +/-   ##
===========================================
+ Coverage   40.00%   64.21%   +24.21%     
===========================================
  Files          11     3614     +3603     
  Lines         170    78750    +78580     
  Branches        0    12446    +12446     
===========================================
+ Hits           68    50567    +50499     
- Misses        102    25132    +25030     
- Partials        0     3051     +3051     
Flag Coverage Δ
Linux_1 30.92% <ø> (?)
Linux_2 55.71% <ø> (?)
Linux_3 40.68% <ø> (?)
Linux_4 31.90% <ø> (?)
Windows_1 30.93% <ø> (-9.07%) ⬇️
Windows_2 55.66% <ø> (?)
Windows_3 40.69% <ø> (?)
Windows_4 31.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc merged commit bcb8355 into opensearch-project:2.x Jul 29, 2024
67 checks passed
Comment on lines +177 to +184
"@babel/code-frame@^7.24.7":
version "7.24.7"
resolved "https://registry.yarnpkg.com/@babel/code-frame/-/code-frame-7.24.7.tgz#882fd9e09e8ee324e496bd040401c6f046ef4465"
integrity sha512-BcYH1CVJBO9tvyIZ2jVeXgSIMvGZ2FDRvDdOIVQyuklNKSsx+eppDEBq/g47Ayw+RqNFE+URvOShmf+f/qwAlA==
dependencies:
"@babel/highlight" "^7.24.7"
picocolors "^1.0.0"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been combined with the block above. Why didn't the resolution do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they shouldn't be combined, 7.22.13 and 7.24.7 are not the same version

"@babel/code-frame@^7.0.0", "@babel/code-frame@^7.10.4", "@babel/code-frame@^7.12.13", "@babel/code-frame@^7.22.13":
version "7.22.13"

Comment on lines +221 to +230
"@babel/generator@^7.25.0":
version "7.25.0"
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.25.0.tgz#f858ddfa984350bc3d3b7f125073c9af6988f18e"
integrity sha512-3LEEcj3PVW8pW2R1SR1M89g/qrYk/m/mB/tLqn7dn4sbBUQyTqnlod+II2U4dqiGtUmkcnAmkMDralTFZttRiw==
dependencies:
"@babel/types" "^7.25.0"
"@jridgewell/gen-mapping" "^0.3.5"
"@jridgewell/trace-mapping" "^0.3.25"
jsesc "^2.5.1"

Copy link
Collaborator

@AMoo-Miki AMoo-Miki Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this... It should have been combined with the block above. Why is it not?

in fact, some other changes should have been combined as well. I would recommend removing the duplicate definitions and doing a bootstrap to fix this.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
* fix babel error

Signed-off-by: Eric <menwe@amazon.com>

* movetesting library to where it was

Signed-off-by: Eric <menwe@amazon.com>

* Changeset file for PR #7541 created/updated

---------

Signed-off-by: Eric <menwe@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit bcb8355)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Jul 29, 2024
* fix babel error



* movetesting library to where it was



* Changeset file for PR #7541 created/updated

---------



(cherry picked from commit bcb8355)

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants