Fix browser warnings #7550
Merged
Fix browser warnings #7550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <2254087899@qq.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7550 +/- ##
==========================================
- Coverage 63.65% 63.65% -0.01%
==========================================
Files 3632 3632
Lines 80060 80059 -1
Branches 12683 12683
==========================================
- Hits 50965 50962 -3
- Misses 25990 25991 +1
- Partials 3105 3106 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba and
zhyuanqi
as code owners
Kapian1234
requested review from
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
ruanyl
previously approved these changes
Jul 30, 2024
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Ok. Thank you! |
SuZhou-Joe
reviewed
Jul 31, 2024
src/plugins/workspace/public/components/home_get_start_card/use_case_footer.tsx
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Jul 31, 2024
src/plugins/workspace/public/components/home_get_start_card/use_case_footer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
ruanyl
previously approved these changes
Aug 2, 2024
Signed-off-by: Jincheng Wan <45655760+Kapian1234@users.noreply.github.com>
ruanyl
approved these changes
Aug 6, 2024
SuZhou-Joe
approved these changes
Aug 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* fix warnings Signed-off-by: Kapian1234 <2254087899@qq.com> * fix warnings Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #7548 created/updated * fix warnings Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #7550 created/updated * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <wanjinch@amazon.com> * remove the duplicate changelogs Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Renamed keys to comply with the directory the file is in Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <2254087899@qq.com> Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: Jincheng Wan <45655760+Kapian1234@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ca89488) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 9, 2024
* fix warnings * fix warnings * Changeset file for PR #7548 created/updated * fix warnings * Changeset file for PR #7550 created/updated * Modified the expect of addNavLinksToGroup in workspace plugin.test.js * Modified the expect of addNavLinksToGroup in workspace plugin.test.js * remove the duplicate changelogs * Renamed keys to comply with the directory the file is in --------- (cherry picked from commit ca89488) Signed-off-by: Kapian1234 <2254087899@qq.com> Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: Jincheng Wan <45655760+Kapian1234@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
keyprops in ‘PageRender’, ‘setupHome’, and ‘HomeListCard’.Resolved 'intl' object not found error by using i18n.translate.
Resolved the issue of duplicate 'addNavLinksToGroup' calls to prevent the "Navlink of workspace_list has already been registered in group settingsAndSetup".
Modified the expect of addNavLinksToGroup in workspace plugin.test.js
Issues Resolved
closes #7515
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration