Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]Add workspaces and permissions fields into saved objects _bulk_get response #7565

Merged
merged 3 commits into from
Jul 30, 2024
Merged

[Workspace]Add workspaces and permissions fields into saved objects _bulk_get response #7565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9df534c
fix missing fields
Hailong-am Jul 30, 2024
60df022
Changeset file for PR #7565 created/updated
opensearch-changeset-bot[bot] Jul 30, 2024
f832063
Merge branch 'main' into missing_fields_bulkget
Hailong-am Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/7565.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- [Workspace]Add workspaces and permissions fields into saved objects _bulk_get response ([#7565](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7565))
6 changes: 5 additions & 1 deletion src/core/server/saved_objects/service/lib/included_fields.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

import { includedFields } from './included_fields';

const BASE_FIELD_COUNT = 9;
const BASE_FIELD_COUNT = 11;

describe('includedFields', () => {
it('returns undefined if fields are not provided', () => {
Expand All @@ -56,6 +56,8 @@ Array [
"migrationVersion",
"updated_at",
"originId",
"workspaces",
"permissions",
"foo",
]
`);
Expand Down Expand Up @@ -90,6 +92,8 @@ Array [
"migrationVersion",
"updated_at",
"originId",
"workspaces",
"permissions",
"foo",
"bar",
]
Expand Down
2 changes: 2 additions & 0 deletions src/core/server/saved_objects/service/lib/included_fields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,7 @@ export function includedFields(type: string | string[] = '*', fields?: string[]
.concat('migrationVersion')
.concat('updated_at')
.concat('originId')
.concat('workspaces')
.concat('permissions')
.concat(fields); // v5 compatibility
}
2 changes: 2 additions & 0 deletions src/core/server/saved_objects/service/lib/repository.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2819,6 +2819,8 @@ describe('SavedObjectsRepository', () => {
'migrationVersion',
'updated_at',
'originId',
'workspaces',
'permissions',
'title',
],
}),
Expand Down
Loading