[Look&Feel] Update paragraph text sizes across remaining OSD #7603

danieldong51 · 2024-07-31T20:57:18Z

Description

This PR updates normal paragraph font size to be small (15.75px next theme / 14px V7 theme).

Screenshot

Data Sources

Area	Before (Inspect)	After (Inspect)	After
Access Description
Accelerations Description
Associated Objects Description
Authentication Description
No Data Source Message
Create: Select Source Description
Create: Page Description
Delete Modal
Permissions Page Description
Data Sources: Description

Dev Tools

Note that the Help change was applied to the entire flyout, excluding the headers (so the commands in bold below are also under <EuiText size='s'>)

Area	Before (Inspect)	After (Inspect)	After
Help
History

Index Patterns

Note that the Scripted Field: Edit change was applied to both the description and the link below.

Area	Before (Inspect)	After (Inspect)	After
Scripted Field: Edit
Details
Scripted Fields
Source Filters
Index Pattern Table

Other Pages

Area	Before (Inspect)	After (Inspect)	After
Dashboard Listing

Changelog

Refactor: [Look&Feel] Update paragraph text sizes across remaining OSD

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-07-31T20:58:05Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-07-31T20:58:59Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-07-31T20:59:24Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

github-actions · 2024-07-31T21:00:09Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-07-31T21:19:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.66%. Comparing base (d09895a) to head (75e1c69).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7603      +/-   ##
==========================================
+ Coverage   63.64%   63.66%   +0.01%     
==========================================
  Files        3632     3632              
  Lines       80043    80060      +17     
  Branches    12677    12683       +6     
==========================================
+ Hits        50943    50969      +26     
+ Misses      25993    25986       -7     
+ Partials     3107     3105       -2

Flag	Coverage Δ
Linux_1	`30.55% <0.00%> (+0.01%)`	⬆️
Linux_2	`55.58% <ø> (ø)`
Linux_3	`40.56% <100.00%> (?)`
Linux_4	`31.30% <0.00%> (+<0.01%)`	⬆️
Windows_1	`30.57% <0.00%> (+0.01%)`	⬆️
Windows_2	`55.53% <ø> (ø)`
Windows_3	`40.56% <100.00%> (+<0.01%)`	⬆️
Windows_4	`31.30% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-31T23:02:20Z

❌ Empty Entry Description

Description for "Skip" entry cannot be empty.

github-actions · 2024-07-31T23:02:42Z

❌ Empty Entry Description

Description for "Skip" entry cannot be empty.

github-actions · 2024-08-01T19:03:19Z

❌ Empty Entry Description

Description for "Skip" entry cannot be empty.

github-actions · 2024-08-01T19:04:43Z

❌ Empty Entry Description

Description for "Skip" entry cannot be empty.

virajsanghvi

Can we add some tests (likely just snapshot tests) to meet patch codecov check?

src/plugins/console/public/application/components/help_panel.tsx

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Updated Data Source Connection paragraph size Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated paragraph size Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated paragraph size Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated paragraph size Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changeset file for PR #7603 created/updated * Removed paragraph tags Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated Snapshot Testing Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated snapshot testing Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated help panel Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated Snapshot Testing for get_no_items_message Signed-off-by: Dan Dong <danieldong51@gmail.com> * Updated Snapshot Testing for get_no_items_message Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changeset file for PR #7603 created/updated * Changeset file for PR #7603 created/updated * Updated Testing for get_no_items_message Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 43dc2d6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…7622) --------- (cherry picked from commit 43dc2d6) Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the valued-contributor label Jul 31, 2024

github-actions bot added the failed changeset label Jul 31, 2024

opensearch-changeset-bot bot added a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024

Changeset file for PR opensearch-project#7603 created/updated

9dfbea4

github-actions bot removed the failed changeset label Aug 1, 2024

danieldong51 pushed a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024

Changeset file for PR opensearch-project#7603 created/updated

c6dde7d

danieldong51 force-pushed the lnf-paragraph-remaining branch from 218ec11 to a533d34 Compare August 1, 2024 19:18

danieldong51 marked this pull request as ready for review August 1, 2024 22:15

danieldong51 requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn and SuZhou-Joe as code owners August 1, 2024 22:15

danieldong51 requested a review from joshuali925 as a code owner August 1, 2024 22:15

virajsanghvi reviewed Aug 1, 2024

View reviewed changes

src/plugins/console/public/application/components/help_panel.tsx Outdated Show resolved Hide resolved

danieldong51 changed the title ~~[Look&Feel] Update paragraph text sizes across remaining OSD~~ [Look&Feel] Update paragraph text sizes across remaining experiences Aug 2, 2024

opensearch-changeset-bot bot added a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Aug 2, 2024

Changeset file for PR opensearch-project#7603 created/updated

7672bb1

opensearch-changeset-bot bot added a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Aug 2, 2024

Changeset file for PR opensearch-project#7603 created/updated

b29e41d

danieldong51 and others added 11 commits August 1, 2024 20:25

Updated Data Source Connection paragraph size

49f2b0b

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated paragraph size

f249583

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated paragraph size

ccc4d9c

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated paragraph size

f196781

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Changeset file for PR opensearch-project#7603 created/updated

8e3b0e3

Removed paragraph tags

a35c0da

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated Snapshot Testing

7b1478b

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated snapshot testing

3624322

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated help panel

8b3e4f6

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated Snapshot Testing for get_no_items_message

0f8d8b1

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Updated Snapshot Testing for get_no_items_message

27152ad

Signed-off-by: Dan Dong <danieldong51@gmail.com>

danieldong51 force-pushed the lnf-paragraph-remaining branch from b29e41d to 27152ad Compare August 2, 2024 17:20

danieldong51 changed the title ~~[Look&Feel] Update paragraph text sizes across remaining experiences~~ [Look&Feel] Update paragraph text sizes across remaining OSD Aug 2, 2024

opensearch-changeset-bot bot and others added 3 commits August 2, 2024 17:22

Changeset file for PR opensearch-project#7603 created/updated

2193514

Changeset file for PR opensearch-project#7603 created/updated

1272baf

Updated Testing for get_no_items_message

75e1c69

Signed-off-by: Dan Dong <danieldong51@gmail.com>

virajsanghvi approved these changes Aug 2, 2024

View reviewed changes

zhongnansu approved these changes Aug 5, 2024

View reviewed changes

zhongnansu added backport 2.x v2.17.0 look & feel Look and Feel Improvements labels Aug 5, 2024

zhongnansu merged commit 43dc2d6 into opensearch-project:main Aug 5, 2024
73 checks passed

opensearch-trigger-bot bot mentioned this pull request Aug 5, 2024

[Backport 2.x] [Look&Feel] Update paragraph text sizes across remaining OSD #7622

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Look&Feel] Update paragraph text sizes across remaining OSD #7603

[Look&Feel] Update paragraph text sizes across remaining OSD #7603

danieldong51 commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

codecov bot commented Jul 31, 2024 •

edited

Loading

github-actions bot commented Jul 31, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Aug 1, 2024

github-actions bot commented Aug 1, 2024

virajsanghvi left a comment

[Look&Feel] Update paragraph text sizes across remaining OSD #7603

[Look&Feel] Update paragraph text sizes across remaining OSD #7603

Conversation

danieldong51 commented Jul 31, 2024 • edited Loading

Description

Screenshot

Data Sources

Dev Tools

Index Patterns

Other Pages

Changelog

Check List

github-actions bot commented Jul 31, 2024

❌ Empty Changelog Section

github-actions bot commented Jul 31, 2024

❌ Empty Changelog Section

github-actions bot commented Jul 31, 2024

❌ Empty Changelog Section

github-actions bot commented Jul 31, 2024

❌ Empty Changelog Section

codecov bot commented Jul 31, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 31, 2024

❌ Empty Entry Description

github-actions bot commented Jul 31, 2024

❌ Empty Entry Description

github-actions bot commented Aug 1, 2024

❌ Empty Entry Description

github-actions bot commented Aug 1, 2024

❌ Empty Entry Description

virajsanghvi left a comment

Choose a reason for hiding this comment

danieldong51 commented Jul 31, 2024 •

edited

Loading

codecov bot commented Jul 31, 2024 •

edited

Loading