-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[navigation]feat: make parent item unclickable and fix duplicate items in landing page. #7619
Merged
SuZhou-Joe
merged 13 commits into
opensearch-project:main
from
SuZhou-Joe:feature/nav-interact
Aug 9, 2024
Merged
[navigation]feat: make parent item unclickable and fix duplicate items in landing page. #7619
SuZhou-Joe
merged 13 commits into
opensearch-project:main
from
SuZhou-Joe:feature/nav-interact
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7619 +/- ##
=======================================
Coverage 63.68% 63.68%
=======================================
Files 3633 3633
Lines 80106 80118 +12
Branches 12693 12694 +1
=======================================
+ Hits 51012 51026 +14
+ Misses 25986 25984 -2
Partials 3108 3108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
August 5, 2024 10:51
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
feature/nav-interact
branch
from
August 7, 2024 07:35
e58d754
to
7afbff0
Compare
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl
reviewed
Aug 8, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl
approved these changes
Aug 8, 2024
ananzh
approved these changes
Aug 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
…s in landing page. (#7619) * feat: make parent item unclickable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7619 created/updated * feat: do not show parent item in landing page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * temp: save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: nav group not reflected when switching to analytics workspace Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 389fd28) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 12, 2024
…s in landing page. (#7619) (#7670) * feat: make parent item unclickable * Changeset file for PR #7619 created/updated * feat: do not show parent item in landing page * fix: unit test * temp: save * feat: update * feat: update * feat: update * feat: optimize code * fix: nav group not reflected when switching to analytics workspace * feat: optimize code * feat: optimize code based on comment * feat: optimize code based on comment --------- (cherry picked from commit 389fd28) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly address 3 issues related to new left navigation.
Issues Resolved
Screenshot
Make parent item unclickable
Only show parent item in landing page and jump to first sub items.
20240807161147146.mp4
Filter out hidden nav group when doing nav group detection (Before fix).
20240807162518193.mp4
Filter out hidden nav group when doing nav group detection (After fix).
20240807162702215.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration