Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get start section cards not aligned #7624

Merged
merged 6 commits into from
Aug 6, 2024
Merged

fix: get start section cards not aligned #7624

merged 6 commits into from
Aug 6, 2024

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Aug 6, 2024 •
edited
Loading

The column size was hard coded to 4 previously, now changed so that it can be configured, this addressed the issue when there are more than 4 cards, cards will be displayed in multiple rows

Description

Before
image

After
image

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: [contentManagement] display cards by specifying a column size or display all cards in one row

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ruanyl
fix: get start section cards not aligned
0e71054 
The column size was hard coded to 4 previously, not changed so that it can be
configured, this addressed the issue when there are more than 4 cards,
cards will be displayed in multiple rows

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
fix ts type
8e2057b 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
tweaks types
37d82ba 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
add a todo item
bde8680 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (43dc2d6) to head (779a6dc).

Files Patch % Lines
...ent/public/components/card_container/card_list.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7624      +/-   ##
==========================================
- Coverage   63.66%   63.66%   -0.01%     
==========================================
  Files        3632     3632              
  Lines       80060    80061       +1     
  Branches    12683    12684       +1     
==========================================
  Hits        50967    50967              
  Misses      25987    25987              
- Partials     3106     3107       +1
Flag Coverage Δ
Linux_1 30.55% <0.00%> (-0.01%) ⬇️
Linux_2 55.58% <ø> (ø)
Linux_3 40.56% <0.00%> (-0.01%) ⬇️
Linux_4 31.29% <0.00%> (-0.01%) ⬇️
Windows_1 30.57% <0.00%> (-0.01%) ⬇️
Windows_2 55.53% <ø> (ø)
Windows_3 40.56% <0.00%> (-0.01%) ⬇️
Windows_4 31.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl and others added 2 commits August 6, 2024 14:08
@ruanyl ruanyl added the v2.17.0 label Aug 6, 2024
@ruanyl ruanyl merged commit aa807e5 into opensearch-project:main Aug 6, 2024
68 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 8, 2024
@github-actions @opensearch-changeset-bot
fix: get start section cards not aligned (#7624)
6c78600 
* fix: get start section cards not aligned

The column size was hard coded to 4 previously, not changed so that it can be
configured, this addressed the issue when there are more than 4 cards,
cards will be displayed in multiple rows

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* fix ts type

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* tweaks types

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* add a todo item

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* fix license header

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* Changeset file for PR #7624 created/updated

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit aa807e5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 8, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Aug 9, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
fix: get start section cards not aligned (#7624) (#7658)
9e704eb 
* fix: get start section cards not aligned

The column size was hard coded to 4 previously, not changed so that it can be
configured, this addressed the issue when there are more than 4 cards,
cards will be displayed in multiple rows



* fix ts type



* tweaks types



* add a todo item



* fix license header



* Changeset file for PR #7624 created/updated

---------



(cherry picked from commit aa807e5)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh ananzh approved these changes

@TackAdam TackAdam TackAdam approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
backport 2.x content-management seasoned-contributor v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruanyl @SuZhou-Joe @ananzh @TackAdam