[Workspace] Set the default color to first color from the palette #7627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form.ts Signed-off-by: Kapian1234 <wanjinch@amazon.com>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Entry Too LongEntry is 111 characters long, which is 11 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7627 +/- ##
==========================================
- Coverage 63.69% 63.68% -0.02%
==========================================
Files 3633 3633
Lines 80104 80105 +1
Branches 12691 12691
==========================================
- Hits 51022 51013 -9
- Misses 25975 25986 +11
+ Partials 3107 3106 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
reviewed
Aug 6, 2024
src/plugins/workspace/public/components/workspace_creator/workspace_creator.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_form/use_workspace_form.ts
Outdated
Show resolved
Hide resolved
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba and
zhyuanqi
as code owners
Kapian1234
requested review from
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
… and updated the type definition of getNumberOfChanges to support partial form data Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…earch-Dashboards into workspace_default_color
SuZhou-Joe
reviewed
Aug 7, 2024
src/plugins/workspace/public/components/workspace_creator/workspace_creator.tsx
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Aug 7, 2024
src/plugins/workspace/public/components/workspace_form/utils.ts
Outdated
Show resolved
Hide resolved
ruanyl
previously approved these changes
Aug 8, 2024
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…earch-Dashboards into workspace_default_color
ruanyl
approved these changes
Aug 8, 2024
SuZhou-Joe
approved these changes
Aug 8, 2024
wanglam
approved these changes
Aug 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
) * src/plugins/workspace/public/components/workspace_form/use_workspace_form.ts Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #7627 created/updated * Separated a new WorkspaceDetailedFormProps for WorkspaceDetailedForm, and updated the type definition of getNumberOfChanges to support partial form data Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Separated defaultWorkspaceFormValues to a constant Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #7627 created/updated * Modified code format Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit cd33e15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 12, 2024
) (#7683) * src/plugins/workspace/public/components/workspace_form/use_workspace_form.ts * Changeset file for PR #7627 created/updated * Separated a new WorkspaceDetailedFormProps for WorkspaceDetailedForm, and updated the type definition of getNumberOfChanges to support partial form data * Separated defaultWorkspaceFormValues to a constant * Changeset file for PR #7627 created/updated * Modified code format --------- (cherry picked from commit cd33e15) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set the default color to first color from the palette in create workspace page
Issues Resolved
#7635
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration