-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not throw exception if content provider id exists #7633
fix: do not throw exception if content provider id exists #7633
Conversation
instead it will overwrite existing content provider Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7633 +/- ##
=======================================
Coverage 63.66% 63.66%
=======================================
Files 3632 3633 +1
Lines 80061 80061
Branches 12684 12682 -2
=======================================
+ Hits 50967 50973 +6
+ Misses 25987 25984 -3
+ Partials 3107 3104 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
❌ Entry Too LongEntry is 172 characters long, which is 72 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
❌ Entry Too LongEntry is 115 characters long, which is 15 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
* fix: do not throw exception if content provider id exists instead it will overwrite existing content provider --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit f08dbdf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) * fix: do not throw exception if content provider id exists instead it will overwrite existing content provider --------- (cherry picked from commit f08dbdf) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Instead of throw error when register section or content with the same id, now changed to override the existing ones.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration