Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw exception if content provider id exists #7633

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Aug 7, 2024

Instead of throw error when register section or content with the same id, now changed to override the existing ones.

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: register section and content with the same id will not throw error but overrides the exist one

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

instead it will overwrite existing content provider

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Copy link
Contributor

github-actions bot commented Aug 7, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (aa807e5) to head (5c3a4f8).
Report is 1 commits behind head on main.

Files Patch % Lines
...agement/public/services/content_management/page.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7633   +/-   ##
=======================================
  Coverage   63.66%   63.66%           
=======================================
  Files        3632     3633    +1     
  Lines       80061    80061           
  Branches    12684    12682    -2     
=======================================
+ Hits        50967    50973    +6     
+ Misses      25987    25984    -3     
+ Partials     3107     3104    -3     
Flag Coverage Δ
Linux_1 30.55% <0.00%> (+<0.01%) ⬆️
Linux_2 55.58% <ø> (ø)
Linux_3 40.57% <75.00%> (?)
Linux_4 31.30% <0.00%> (+<0.01%) ⬆️
Windows_1 30.57% <0.00%> (+<0.01%) ⬆️
Windows_2 55.53% <ø> (ø)
Windows_3 40.57% <75.00%> (+<0.01%) ⬆️
Windows_4 31.30% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

❌ Entry Too Long

Entry is 172 characters long, which is 72 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

❌ Entry Too Long

Entry is 115 characters long, which is 15 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

@ananzh ananzh merged commit f08dbdf into opensearch-project:main Aug 7, 2024
67 checks passed
@ananzh ananzh added v2.17.0 enhancement New feature or request labels Aug 7, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 8, 2024
* fix: do not throw exception if content provider id exists
instead it will overwrite existing content provider

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f08dbdf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 9, 2024
)

* fix: do not throw exception if content provider id exists
instead it will overwrite existing content provider

---------



(cherry picked from commit f08dbdf)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants