feat: [contentManagement] allow to update section input after page rendered #7651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible a dashboard rendered by content management plugin to update the query, time range and filters on the fly Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7651 +/- ##
=======================================
Coverage 63.68% 63.68%
=======================================
Files 3633 3633
Lines 80101 80122 +21
Branches 12690 12697 +7
=======================================
+ Hits 51009 51026 +17
- Misses 25985 25987 +2
- Partials 3107 3109 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Closed
6 tasks
TackAdam
approved these changes
Aug 12, 2024
SuZhou-Joe
approved these changes
Aug 13, 2024
SuZhou-Joe
reviewed
Aug 13, 2024
| query: { | ||
| query: '', | ||
| language: 'lucene', | ||
| language: 'kuery', |
There was a problem hiding this comment.
What's the difference between the language here? I guess it will be overwritten by ...section.input?
There was a problem hiding this comment.
Yes, it can be override by section.input. Here it just changed the default language from lucene to kuery(DQL).
AMoo-Miki
reviewed
Aug 13, 2024
| } | ||
|
|
||
| const updated = callback(section); | ||
| if (updated) { |
There was a problem hiding this comment.
How would you feel about doing
if (updated.kind !== section.kind) return;
... and then a switch-case for dashboard, card, and custom?
There was a problem hiding this comment.
Good idea! I will adopt this change in the upcoming PR
There was a problem hiding this comment.
Seems TS compiler is not happy with that ;D
AMoo-Miki
approved these changes
Aug 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
…ndered (#7651) * feat: allow to update section input on the fly This makes it possible a dashboard rendered by content management plugin to update the query, time range and filters on the fly Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR #7651 created/updated * fix(linter): add license header Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b68754e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Aug 15, 2024
…ndered (#7651) (#7694) * feat: allow to update section input on the fly This makes it possible a dashboard rendered by content management plugin to update the query, time range and filters on the fly * Changeset file for PR #7651 created/updated * fix(linter): add license header --------- (cherry picked from commit b68754e) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to update the section input after the page is rendered, for example, when rendering a dashboard on the page, we need to apply the date range, filter and query on the fly.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration