Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Workspace]Fix page crash caused by invalid workspace color #7681

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 248c8ff from #7671.

* Add validation for workspace color

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #7671 created/updated

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 248c8ff)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (f2f363a) to head (efa37ef).

Files Patch % Lines
...orkspace/public/components/workspace_form/utils.ts 71.42% 1 Missing and 1 partial ⚠️
src/plugins/workspace/server/routes/index.ts 0.00% 2 Missing ⚠️
...ublic/components/workspace_menu/workspace_menu.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7681   +/-   ##
=======================================
  Coverage   63.78%   63.78%           
=======================================
  Files        3633     3634    +1     
  Lines       80167    80181   +14     
  Branches    12689    12696    +7     
=======================================
+ Hits        51134    51143    +9     
- Misses      25930    25979   +49     
+ Partials     3103     3059   -44     
Flag Coverage Δ
Linux_1 30.64% <66.66%> (+<0.01%) ⬆️
Linux_2 55.75% <ø> (ø)
Linux_3 40.62% <ø> (-0.01%) ⬇️
Linux_4 31.46% <ø> (ø)
Windows_1 30.66% <66.66%> (+<0.01%) ⬆️
Windows_2 55.70% <ø> (ø)
Windows_3 40.62% <ø> (ø)
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 5605fc4 into 2.x Aug 12, 2024
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset seasoned-contributor v2.17.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants