[Rename] Refactored src/cli_plugin/* #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
reviewed
Mar 5, 2021
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
approved these changes
Mar 12, 2021
|
|
||
| it('produces expected defaults', function () { | ||
| expect(parse(command, { ...defaultOptions }, kbnPackage)).toMatchInlineSnapshot(` | ||
| expect(parse(command, { ...defaultOptions }, osdPackage)).toMatchInlineSnapshot(` | ||
| Object { | ||
| "config": "", | ||
| "plugin": "plugin name", |
There was a problem hiding this comment.
NIT: looks like a test and could probably can replace line 64 and 91: elastic and kibana plugins?
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* [Rename] Refactored src/cli_plugin/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/cli_plugin/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/cli_plugin/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/cli_plugin/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/cli_plugin/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/cli_plugin/* Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] accomodate PR review feedback Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 9, 2023
refactor: move workspace uiSettings registration to workspace service --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
refactor: move workspace uiSettings registration to workspace service --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
refactor: move workspace uiSettings registration to workspace service --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #37
Description of changes: ctored src/cli_plugin/*
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.