Allow screenTitle to be present when SearchBar is not in Application header
#7721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
virajsanghvi
approved these changes
Aug 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7721 +/- ##
==========================================
- Coverage 63.82% 63.82% -0.01%
==========================================
Files 3643 3651 +8
Lines 80644 80953 +309
Branches 12822 12886 +64
==========================================
+ Hits 51469 51665 +196
- Misses 26039 26124 +85
- Partials 3136 3164 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manasvinibs
approved these changes
Aug 15, 2024
|
Build and Verify CI 1 failure is related to a bad PR being merged: #7699 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
…n header (#7721) * Allow `screenTitle` to be present when SearchBar is not Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #7721 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 577b3ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Aug 19, 2024
…n header (#7721) (#7722) * Allow `screenTitle` to be present when SearchBar is not * Changeset file for PR #7721 created/updated --------- (cherry picked from commit 577b3ec) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
screenTitleto be present when SearchBar is not in Application headerChangelog
screenTitleto be present when SearchBar is not in Application headerCheck List
yarn test:jestyarn test:jest_integration