[Workspace] Refactor: workspace detail page header #7771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7771 +/- ##
==========================================
- Coverage 63.80% 63.79% -0.01%
==========================================
Files 3656 3656
Lines 81210 81209 -1
Branches 12950 12952 +2
==========================================
- Hits 51812 51811 -1
Misses 26217 26217
Partials 3181 3181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
…rch-Dashboards into 2.17/detail-page-header
SuZhou-Joe
reviewed
Aug 21, 2024
src/plugins/workspace/public/components/workspace_detail/workspace_detail.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
previously approved these changes
Aug 21, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
AMoo-Miki
reviewed
Aug 22, 2024
src/plugins/workspace/public/components/workspace_detail/workspace_detail.test.tsx
Outdated
Show resolved
Hide resolved
AMoo-Miki
reviewed
Aug 22, 2024
src/plugins/workspace/public/components/workspace_detail/workspace_detail.tsx
Outdated
Show resolved
Hide resolved
AMoo-Miki
reviewed
Aug 22, 2024
src/plugins/workspace/public/components/workspace_form/workspace_detail_form.tsx
Show resolved
Hide resolved
AMoo-Miki
reviewed
Aug 22, 2024
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx
Outdated
Show resolved
Hide resolved
AMoo-Miki
reviewed
Aug 22, 2024
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <yubonluo@amazon.com>
7 tasks
SuZhou-Joe
approved these changes
Aug 22, 2024
ruanyl
approved these changes
Aug 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix workspace detail page header Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7771 created/updated * optimize workspace detail page header Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Add delete unit test flow Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit a59f8ab) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix workspace detail page header * Changeset file for PR #7771 created/updated * optimize workspace detail page header * optimize the code * Add delete unit test flow * optimize the code --------- (cherry picked from commit a59f8ab) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workspace detail page header support description and button.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration