[Rename] kbn-apm-config-loader to osd-apm-config-loader #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
mihirsoni
reviewed
Mar 5, 2021
| @@ -24,7 +24,7 @@ import { ApmConfiguration } from './config'; | |||
| * Load the APM configuration. | |||
| * | |||
| * @param argv the `process.argv` arguments | |||
| * @param rootDir The root directory of kibana (where the sources and the `package.json` file are) | |||
| * @param rootDir The root directory of opensearchDashboards (where the sources and the `package.json` file are) | |||
There was a problem hiding this comment.
This should be opensearch-dashboards.
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
force-pushed
the
rename-kbn-apm-config-loader
branch
from
2b89127
to
a46a377
Compare
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* [Rename] kbn-apm-config-loader to osd-apm-onfig-loader Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Handle PR comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] kbn-apm-config-loader to osd-apm-onfig-loader Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Handle PR comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni
pushed a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] kbn-apm-config-loader to osd-apm-onfig-loader Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Handle PR comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 9, 2023
…ject#78) refactor: simplified ACL transformPermission function --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
…ject#78) refactor: simplified ACL transformPermission function --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
…ject#78) refactor: simplified ACL transformPermission function --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issue #, if available:
#37
Description of changes:
Rename folders, files, and variables to osd-apm-config-loader
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.