[Look&Feel] Updated Discover No Results panel #7891

danieldong51 · 2024-08-28T19:00:23Z

Description

Updates empty prompt in Discover. Comments out the Lucene Query Message prompt due to #8149.

Screenshot

Before	After

Testing the changes

Changelog

refactor: [Look&Feel] Updated Discover No Results panel

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-08-28T19:01:06Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-08-28T19:16:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.04%. Comparing base (21f4218) to head (7412c35).
Report is 42 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7891   +/-   ##
=======================================
  Coverage   64.04%   64.04%           
=======================================
  Files        3740     3740           
  Lines       88608    88603    -5     
  Branches    13799    13797    -2     
=======================================
- Hits        56746    56744    -2     
+ Misses      31264    31261    -3     
  Partials      598      598

Flag	Coverage Δ
Linux_1	`30.03% <ø> (+<0.01%)`	⬆️
Linux_2	`58.83% <ø> (ø)`
Linux_3	`40.37% <ø> (+<0.01%)`	⬆️
Linux_4	`31.46% <ø> (-0.01%)`	⬇️
Windows_1	`30.05% <ø> (+<0.01%)`	⬆️
Windows_2	`58.78% <ø> (ø)`
Windows_3	`40.37% <ø> (+<0.01%)`	⬆️
Windows_4	`31.46% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-30T17:15:27Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

virajsanghvi

Will take over this pr, but lmk about the localization q

virajsanghvi · 2024-09-13T20:38:22Z

src/plugins/discover/public/application/components/no_results/no_results.tsx

+  // Commented out due to no usage in code
+  // See: https://github.com/opensearch-project/OpenSearch-Dashboards/issues/8149
+  //
+  // let luceneQueryMessage;


nit: Not a huge fan of dead code, but sounds like @ashwin-pc requested this so fine as is

virajsanghvi · 2024-09-13T20:40:59Z

src/plugins/discover/public/application/components/no_results/no_results.tsx

+            <EuiText size="s">
+              <h2>No results</h2>
+            </EuiText>
+          }
+          body={
+            <EuiText size="s" data-test-subj="discoverNoResultsTimefilter">
+              <p>
+                Try selecting a different data source, expanding your time range or modifying the
+                query &amp; filters.
+              </p>
+            </EuiText>


Is there a reason we're not localizing this text?

Just updated with localization!

Signed-off-by: Dan Dong <danieldong51@gmail.com> Update src/plugins/discover/public/application/components/no_results/no_results.tsx Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> Updated Discover No Results panel Signed-off-by: Dan Dong <danieldong51@gmail.com>

Signed-off-by: Dan Dong <danieldong51@gmail.com>

zhongnansu

lgtm

comments was addressed and resolved

* Empty Prompt changes Signed-off-by: Dan Dong <danieldong51@gmail.com> Update src/plugins/discover/public/application/components/no_results/no_results.tsx Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> Updated Discover No Results panel Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changeset file for PR #7891 created/updated * Changes for Cypress tests Signed-off-by: Dan Dong <danieldong51@gmail.com> * Added localization Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 5d1c21b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Empty Prompt changes Update src/plugins/discover/public/application/components/no_results/no_results.tsx Updated Discover No Results panel * Changeset file for PR #7891 created/updated * Changes for Cypress tests * Added localization --------- (cherry picked from commit 5d1c21b) Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…ject#7891) (opensearch-project#8224)" This reverts commit 10bb541.

github-actions bot added the seasoned-contributor label Aug 28, 2024

github-actions bot added the failed changeset label Aug 28, 2024

danieldong51 force-pushed the discover_no_results branch from 1eb28e5 to 4bc9fc9 Compare August 30, 2024 17:08

danieldong51 changed the title ~~Updated Discover No Results panel~~ [Look&Feel] Updated Discover No Results panel Aug 30, 2024

github-actions bot removed the failed changeset label Aug 30, 2024

opensearch-changeset-bot bot added a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Aug 30, 2024

Changeset file for PR opensearch-project#7891 created/updated

2b7c8ae

danieldong51 marked this pull request as ready for review August 30, 2024 17:18

danieldong51 requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric and LDrago27 as code owners August 30, 2024 17:18

danieldong51 force-pushed the discover_no_results branch from 70dec94 to 10b578b Compare September 11, 2024 20:56

danieldong51 pushed a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Sep 11, 2024

Changeset file for PR opensearch-project#7891 created/updated

e06b51e

danieldong51 force-pushed the discover_no_results branch from 10b578b to e06b51e Compare September 11, 2024 20:57

danieldong51 marked this pull request as ready for review September 11, 2024 20:58

danieldong51 requested a review from huyaboo as a code owner September 11, 2024 20:58

danieldong51 pushed a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Sep 12, 2024

Changeset file for PR opensearch-project#7891 created/updated

31b473b

danieldong51 force-pushed the discover_no_results branch from 6427f7d to 80348c1 Compare September 12, 2024 22:14

virajsanghvi reviewed Sep 13, 2024

View reviewed changes

danieldong51 and others added 4 commits September 13, 2024 14:11

Changeset file for PR opensearch-project#7891 created/updated

5f93a99

Changes for Cypress tests

491fd61

Signed-off-by: Dan Dong <danieldong51@gmail.com>

Added localization

7412c35

Signed-off-by: Dan Dong <danieldong51@gmail.com>

danieldong51 force-pushed the discover_no_results branch from 36a1fa1 to 7412c35 Compare September 13, 2024 21:11

virajsanghvi approved these changes Sep 13, 2024

View reviewed changes

virajsanghvi added backport 2.x look & feel Look and Feel Improvements 2.17.1 labels Sep 16, 2024

zhongnansu approved these changes Sep 16, 2024

View reviewed changes

virajsanghvi merged commit 5d1c21b into opensearch-project:main Sep 16, 2024
73 checks passed

opensearch-trigger-bot bot mentioned this pull request Sep 16, 2024

[Backport 2.x] [Look&Feel] Updated Discover No Results panel #8208

Merged

virajsanghvi added the backport 2.17 label Sep 18, 2024

opensearch-trigger-bot bot mentioned this pull request Sep 18, 2024

[Backport 2.17] [Look&Feel] Updated Discover No Results panel #8224

Merged

abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024

Revert "[Look&Feel] Updated Discover No Results panel (opensearch-pro…

52c36b9

…ject#7891) (opensearch-project#8224)" This reverts commit 10bb541.

virajsanghvi added the v2.18.0 label Sep 26, 2024

AMoo-Miki added the in-next label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Look&Feel] Updated Discover No Results panel #7891

[Look&Feel] Updated Discover No Results panel #7891

danieldong51 commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024

codecov bot commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 30, 2024

virajsanghvi left a comment

virajsanghvi Sep 13, 2024

virajsanghvi Sep 13, 2024

danieldong51 Sep 13, 2024 •

edited

Loading

zhongnansu left a comment

[Look&Feel] Updated Discover No Results panel #7891

[Look&Feel] Updated Discover No Results panel #7891

Conversation

danieldong51 commented Aug 28, 2024 • edited Loading

Description

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented Aug 28, 2024

❌ Empty Changelog Section

codecov bot commented Aug 28, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 30, 2024

❌ Empty Changelog Section

virajsanghvi left a comment

Choose a reason for hiding this comment

virajsanghvi Sep 13, 2024

Choose a reason for hiding this comment

virajsanghvi Sep 13, 2024

Choose a reason for hiding this comment

danieldong51 Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

zhongnansu left a comment

Choose a reason for hiding this comment

danieldong51 commented Aug 28, 2024 •

edited

Loading

codecov bot commented Aug 28, 2024 •

edited

Loading

danieldong51 Sep 13, 2024 •

edited

Loading