-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data connection saved-object type for external connections #7925
Add Data connection saved-object type for external connections #7925
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 7925.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7925 +/- ##
=======================================
Coverage 61.11% 61.11%
=======================================
Files 3691 3691
Lines 87340 87340
Branches 13435 13435
=======================================
Hits 53381 53381
Misses 30706 30706
Partials 3253 3253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/data_source/server/saved_objects/data_connection_saved_objects_client_wrapper.ts
Outdated
Show resolved
Hide resolved
f5e633d
to
d57311b
Compare
Signed-off-by: Megha Goyal <goyamegh@amazon.com>
0d21468
to
cd8e468
Compare
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
8632bae
* Add Data connection saved-object type for external connections Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Changeset file for PR #7925 created/updated --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3caaa9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add Data connection saved-object type for external connections Signed-off-by: Megha Goyal <goyamegh@amazon.com> * Changeset file for PR #7925 created/updated --------- Signed-off-by: Megha Goyal <goyamegh@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3caaa9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#8000) * Add Data connection saved-object type for external connections * Changeset file for PR #7925 created/updated --------- (cherry picked from commit 3caaa9d) Signed-off-by: Megha Goyal <goyamegh@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
#8001) * Add Data connection saved-object type for external connections * Changeset file for PR #7925 created/updated --------- (cherry picked from commit 3caaa9d) Signed-off-by: Megha Goyal <goyamegh@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Huy Nguyen <73027756+huyaboo@users.noreply.github.com>
type: 'text', | ||
}, | ||
type: { | ||
type: 'text', | ||
}, | ||
meta: { | ||
type: 'text', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these types be keyword
? and what is meta
?
Description
Today MDS plugin only supports OpenSearch datasources. With the new saved-object type data-connection, the intention is to allow the external data connections like CloudWatch and Security Lake.
Issues Resolved
NA
Screenshot
NA
Testing the changes
Saved objects API testing sample inputs (unit tests added as well):
Changelog
Check List
yarn test:jest
yarn test:jest_integration